[erlang-questions] Would like some feedback

[Sergej Jurečko]

What I would suggest is separating the axolotl bits from mnesia/gen_fsm bits. Your library needlessly imposes an architecture on the user. 

Sergej

> On 24 Nov 2015, at 19:18, Frans Schneider <schneider@REDACTED> wrote:
> 
> Dear list,
> 
> I've been learning Erlang in my spare-time for some time now and would love some feedback on a project I recently started. Since I have no coworkers or other people to get feedback from, maybe somebody on this list could have a quick look. 
> The things I find particular difficult is defining a proper API, to decide what goes into a new process or is done in the calling process and dealing with errors. I have no formal training as a programmer which may be the reason I have trouble to get these things right.
> 
> The project I took [1] was to implement the Axolotl ratcheting protocol from Open Whisper Systems [2]. The protocol [3] itself didn't look very difficult, but since there are no proper specs for the total system, I used the libaxolotl-java implementation as a starting pont [4]. Reading the Java code probably was the hardest part of the whole project.
> 
> I think I covered most of the functionality of the libaxolotl-java library. I haven't verified interoperability between my implementation and libaxolotl-java since that would require me to start coding in Java which is not something I am looking forward to.
> Comparing my Erlang code with the original Java code, I needed far less lines of code and, I think, the code is much easier to understand. Also, building and deploying the code seems much simpler. 
> 
> So, any comments are most welcome.
> 
> Thanks,
> 
> Frans
> 
> [1] https://github.com/schnef/axolotl <https://github.com/schnef/axolotl>
> [2] https://www.whispersystems.org/ <https://www.whispersystems.org/>
> [3] https://github.com/trevp/axolotl/wiki <https://github.com/trevp/axolotl/wiki>
> [4] https://github.com/WhisperSystems/libaxolotl-java <https://github.com/WhisperSystems/libaxolotl-java>
> Nice implementation https://github.com/rxcomm/pyaxo <https://github.com/rxcomm/pyaxo>
> _______________________________________________
> erlang-questions mailing list
> erlang-questions@REDACTED
> http://erlang.org/mailman/listinfo/erlang-questions

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20151124/7b213a34/attachment.htm>