[erlang-questions] obsolete comment in mnesia?

Håkan Mattsson hm@REDACTED
Sun Dec 25 19:04:07 CET 2011


On Fri, Dec 23, 2011 at 7:50 PM, Ulf Wiger <ulf@REDACTED> wrote:
>
> I found this in mnesia_schema.erl during some of my Christmas code browsing:
>
> read_nodes() ->
>    %% Ensure that we access the intended Mnesia
>    %% directory. This function may not be called
>    %% during startup since it will cause the
>    %% application_controller to get into deadlock
>    case mnesia_lib:ensure_loaded(?APPLICATION) of
>        ok ->
>            …
>   end.
>
>
> As far as I can tell, there is absolutely no risk of deadlock, but I recall a time, a
> looong time ago, when application:loaded_applications() was actually implemented
> as a gen_server:call(), and calling it during application start would result in a
> deadlock. If memory serves, this was corrected sometime around 1996-97...

I added the comment after I encountered an actual deadlock in Mnesia.
It was probably sometime during 1996 or 1997.

> Is there something else I'm missing, or would it be ok to remove this comment?

Remove the comment iff it is wrong.

/Håkan



More information about the erlang-questions mailing list