[erlang-patches] Re: [erlang-questions] Bug in epmd_srv.c?

[Klas Johansson]

2009/12/21 Björn Gustavsson <bgustavsson@REDACTED>:
> On Sun, Dec 20, 2009 at 11:06 PM, Klas Johansson
> <klas.johansson@REDACTED> wrote:
>> Now I too have been bitten by this.  This patch places the
>> `highest version' field before the `lowest version' field in the
>> docs, just as in the source code:
>>
>
> Thanks!
>
> I have applied your patch directly to the development branch
> (it will turn up later today in the git repository), with one minor
> change (referring to the next field for possible values no longer
> make sense, so I copied the line "The value in R6B and later is 5"
> from the other version number).

Ok, great!

>>> Secondly, in erts/epmd/src/epmd_srv.c:628 (R13B01), there is
>>> the following line:
>>>
>>>     offset += (strlen(node->extra)-1);
> [...]
>
> I'll wait for your updated version.

I've amended my previous patch to incorporate the fix for the
what-if-extra-contains-null-characters issue.  Get it here:

   git fetch git://github.com/klajo/otp.git epmd_port2resp_trunc_extra

I've also attached a new version of the erlang test case which
tests the null issue as well.  I'd be happy to hear what you
think.

BR,
Klas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: epmd_extra.erl
Type: application/octet-stream
Size: 2916 bytes
Desc: not available
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20091222/7fb64ae5/attachment.obj>