[erlang-questions] [PATCH R12B-0] fix HiPE no_remove_comments option regression

Mikael Pettersson <>
Fri Dec 7 15:44:53 CET 2007


This patch corrects the HiPE compiler to not crash if the
user passes the no_remove_comments option to it.
The default is to remove internally generated comment
instructions as soon as possible, which is why we didn't
catch this error before.

This change has been committed and will appear in R12B-1.

--- otp_src_R12B-0/lib/hipe/icode/hipe_icode_range.erl.~1~	2007-11-26 20:01:41.000000000 +0100
+++ otp_src_R12B-0/lib/hipe/icode/hipe_icode_range.erl	2007-12-07 13:12:38.000000000 +0100
@@ -163,7 +163,8 @@ analyse_insn(I, Info, LookupFun) ->
       #move{} -> analyse_move(NewI);
       #phi{} -> analyse_phi(NewI);
       #fmove{} -> analyse_fmove(NewI);
-      #begin_handler{} -> analyse_begin_handler(NewI)
+      #begin_handler{} -> analyse_begin_handler(NewI);
+      #comment{} -> NewI
     end,
   {enter_vals(FinalI,Info), FinalI}.
 



More information about the erlang-questions mailing list