<div dir="ltr">Hi Andreas,<div><br></div><div> Ahh sorry about that. I've amended my commit message, which is commit hash <span style="color:rgb(68,68,68);font-family:Monaco,'Liberation Mono',Courier,monospace;font-size:11px;line-height:15.399999618530273px">eadc39c5356692d8a093b835d884c8e11faf4c73 .</span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 15, 2014 at 9:32 AM, Andreas Schumacher <span dir="ltr"><<a href="mailto:andreas@erlang.org" target="_blank">andreas@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thank you for your contribution! However, before we continue working with this patch, please provide a better commit message, according to the following guidelines for "Writing good commit messages [1]. <div>
<br></div><div>[1] <a href="https://github.com/erlang/otp/wiki/Writing-good-commit-messages" target="_blank">https://github.com/erlang/otp/wiki/Writing-good-commit-messages</a></div><div><br></div><div>Andreas Schumacher, Erlang/OTP, Ericsson AB<div>
<div class="gmail_quote"><br></div><div class="gmail_quote"><br><div lang="EN-US" link="blue" vlink="purple"><div>
<p class="MsoNormal"><b><span style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span style="font-size:10pt;font-family:Tahoma,sans-serif"> <a href="mailto:erlang-patches-bounces@erlang.org" target="_blank">erlang-patches-bounces@erlang.org</a> [mailto:<a href="mailto:erlang-patches-bounces@erlang.org" target="_blank">erlang-patches-bounces@erlang.org</a>]
<b>On Behalf Of </b>Colton Leekley-Winslow<br>
<b>Sent:</b> den 11 april 2014 15:09<br>
<b>To:</b> <a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a><br>
<b>Subject:</b> [erlang-patches] Patch for bug in snmp_test_manager.erl<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hi,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"> Recently I was familiarizing myself with the SNMP functionality of Erlang and decided to use the snmp_test_manager (lib/snmp/test/snmp_test_manager.erl) setup as a guide. During my endeavor I was unable to start_link an snmp_test_manager
due to a badmatch occurring on line 133. See traceback here: <a href="http://pastebin.com/1eNYkGTz" target="_blank">http://pastebin.com/1eNYkGTz</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This is because on line 133 the snmp_test_manager module is expecting a tuple of {ok, Pid} from snmpm:start_link/0 . However, snmpm:start_link/0 will only return the atom ok. This causes a badmatch. By editing line 133 of snmp_test_manager.erl
to only expect the atom ok, and editing line 136 to not reference the no longer existing Pid variable, I was able to fix the module. I also edited line 59 to remove the mgr key from the State record, as after these changes it was no longer being used. You
can find my public repository here:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><a href="https://github.com/telsacolton/otp" target="_blank">https://github.com/telsacolton/otp</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">and the branch with the fix is called <u></u><u></u></p>
<table border="0" cellspacing="0" cellpadding="0" width="920" style="width:690pt;border-collapse:collapse;border-spacing:0px">
<tbody>
<tr>
<td style="border-style:none none solid;border-bottom-color:rgb(221,221,221);border-bottom-width:1pt;background-color:rgb(250,250,250);padding:3.75pt 0cm">
<h3 style="margin:0cm 0cm 0.0001pt"><span style="font-family:Helvetica,sans-serif;color:rgb(51,51,51)"><a href="https://github.com/telsacolton/otp/tree/snmp_test_manager_badmatch_pid" target="_blank"><span style="font-family:Arial,sans-serif;color:black;font-weight:normal">snmp_test_manager_badmatch_pid</span></a><u></u><u></u></span></h3>
</td>
</tr>
</tbody>
</table>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal">-- <u></u><u></u></p>
<div>
<p class="MsoNormal">Colton Leekley-Winslow<u></u><u></u></p>
<div>
<p class="MsoNormal">Developer, Telsasoft<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><a href="tel:%28952%29%20707-8581" value="+19527078581" target="_blank">(952) 707-8581</a><u></u><u></u></p>
</div>
</div>
</div>
</div>
</div></div></div>
</div>
</div><br></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Colton Leekley-Winslow<div>Developer, Telsasoft</div><div><span style="line-height:16px">(952) 707-8581</span><br></div></div>
</div>