<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi<br>
As I mentioned in the previous email, I created a pull request from
your branch.<br>
Now that you are adding to it, It would be nice if you could create
your own PR from your branch so that you can keep that up to date.<br>
<br>
Also, keep in mind the guidelines for writing good commit messages.<br>
<a class="moz-txt-link-freetext" href="https://github.com/erlang/otp/wiki/Writing-good-commit-messages">https://github.com/erlang/otp/wiki/Writing-good-commit-messages</a><br>
<br>
<br>
Thank you for your contributions!<br>
<br>
<div class="moz-cite-prefix">On 2014-03-24 15:30, Jean-Sébastien
Pédron wrote:<br>
</div>
<blockquote cite="mid:53304196.20909@dumbbell.fr" type="cite">
<pre wrap="">On 20.03.2014 11:15, Siri Hansen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">It would be really good if you could add a test case for it also, so
it does not happen again.
</pre>
</blockquote>
<pre wrap="">
I pushed a second commit to the same branch to add a test case.
Here's the branch information again, just in case:
git fetch git://github.com/dumbbell/otp.git
function_clause-in-systools_make-format_error
<a class="moz-txt-link-freetext" href="https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error">https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error</a>
<a class="moz-txt-link-freetext" href="https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch">https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch</a>
Thank you!
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
/Henrik Nord Erlang/OTP</pre>
</body>
</html>