<div dir="ltr"><div>Hi Lukas,</div><div><br></div>If I recall correctly, I did that so that the exact failure reason would be more obvious when dtrace fails build. When I first ran into this problem months ago it was hard for me to determine what the issue was and my thinking is that this output would help. Perhaps it is not useful? I will not object if you feel this particular change needs to be reverted but I also didn't make the change by accident.<div>
<br></div><div>-Z</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Feb 4, 2014 at 12:24 PM, Lukas Larsson <span dir="ltr"><<a href="mailto:lukas@erlang.org" target="_blank">lukas@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hello Ryan,<br>
<br>
I just noticed that you removed the "2> /dev/null" for the
2STEP_TEST in erts/<a href="http://configure.in" target="_blank">configure.in</a>. Was there a reason for doing that?
As it is now when the test fails on osx in prints the output of the
dtrace command to the shell which is not really what you want.<div class="im"><br>
<br>
Lukas<br>
<div>On 15/01/14 23:32, Ryan Zezeski wrote:<br>
</div>
</div><div><div class="h5"><blockquote type="cite">
<div dir="ltr">Any news? Would be nice if R17 worked with DTrace
on latest Illumos kernel.</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Tue, Dec 10, 2013 at 8:26 AM, Henrik
Nord <span dir="ltr"><<a href="mailto:henrik@erlang.org" target="_blank">henrik@erlang.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Thank you for your
contribution !<br>
<br>
patch <span style="color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:22px;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(251,251,251);display:inline!important;float:none">has
been assigned to be reviewed</span>
<div>
<div><br>
<br>
<br>
<div>On 2013-12-07 22:00, Ryan Zezeski wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div>
<div dir="ltr"><a href="https://github.com/erlang/otp/pull/156" target="_blank">https://github.com/erlang/otp/pull/156</a><br>
<div><br>
</div>
<div>This patch fixes the configure and Makefile
scripts to work with newer DTrace. This applies
to all Illumos derivatives including
OpenIndiana, SmartOS and OmnioOS. I've copied
the commit message here verbatim.</div>
<div><br>
</div>
<div>--- SNIP ---</div>
<div><br>
</div>
<div>
<div> Fix DTrace build on Illumos</div>
<div><br>
</div>
<div> DTrace was recently patched in Illumos
to fail to create an object</div>
<div> file if no probes are found.</div>
<div><br>
</div>
<div> * <a href="https://www.illumos.org/issues/4248" target="_blank">https://www.illumos.org/issues/4248</a></div>
<div> * <a href="https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59" target="_blank">https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59</a></div>
<div><br>
</div>
<div> This patch fixes two issues:</div>
<div><br>
</div>
<div> * Modify the configure script to pass
an object file to `dtrace -G`</div>
<div> that actually invokes a probe.</div>
<div><br>
</div>
<div> * Remove creation of `dtrace_user.o`
from the dyntrace Makefile. In a</div>
<div> previous commit [1] Scott Fritchie
relocated all the user probes</div>
<div> into the VM proper due to
difficulties with DTrace probes in shared</div>
<div> libraries. The `dtrace_user.d` file
is now empty and generates a</div>
<div> header file with nothing in it. There
is no longer any reason to</div>
<div> generate `dtrace_user.o` because all
the probes are in the VM. Thus</div>
<div> all the steps for building
`dtrace_user.o` have been removed.</div>
<div><br>
</div>
<div> [1]: <a href="https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99" target="_blank">https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99</a></div>
</div>
<div><br>
</div>
<div>--- END SNIP ---</div>
<div><br>
</div>
<div>-Z</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
erlang-patches mailing list
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><span><font color="#888888">
</font></span></pre>
<span><font color="#888888"> </font></span></blockquote>
<span><font color="#888888"> <br>
<pre cols="72">--
/Henrik Nord Erlang/OTP</pre>
</font></span></div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
erlang-patches mailing list
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>