<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 2013-05-20 15:02, Dan Gudmundsson
wrote:<br>
</div>
<blockquote
cite="mid:CANX4uuO_4EKhyx30ZWQUz9qyksR3mMLxg5W6wfRT80pAeKJE9w@mail.gmail.com"
type="cite">
<div dir="ltr">Hi
<div><br>
</div>
<div>I believe the bug is that block_table is called twice, I
don't think that should happen.<br>
</div>
<div style="">It was some time ago I wrote that part, so can you
try to investigate why that happens?</div>
<div style=""><br>
</div>
<div style="">I do not want to take this patch as it is, without
knowing why it happens, since it may mask</div>
<div style="">other more serious faults.</div>
<div style=""><br>
</div>
<div style="">/Dan</div>
</div>
</blockquote>
<br>
Ping!<br>
<br>
<blockquote
cite="mid:CANX4uuO_4EKhyx30ZWQUz9qyksR3mMLxg5W6wfRT80pAeKJE9w@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, May 2, 2013 at 10:23 AM, Ahmed
Omar <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:spawn.think@gmail.com" target="_blank">spawn.think@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Thanks Fredrik for your comments, to avoid
confusing commits,
<div>
<div>Please fetch from </div>
<div><br>
</div>
<div><span
style="font-size:12.727272033691406px;font-family:arial,sans-serif">git
fetch git://</span><a moz-do-not-send="true"
href="http://github.com/spawnthink/otp.git"
style="font-family:arial,sans-serif;font-size:12.727272033691406px"
target="_blank">github.com/spawnthink/otp.git</a><span
style="font-size:12.727272033691406px;font-family:arial,sans-serif"> </span><font
style="font-size:12.727272033691406px;font-family:arial,sans-serif"
color="#000000" face="arial, sans-serif">fix_mnesia_block_table_exception</font><br>
</div>
<div><font
style="font-size:12.727272033691406px;font-family:arial,sans-serif"
color="#000000" face="arial, sans-serif"><br>
</font></div>
<div><a moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_mnesia_block_table_exception"
target="_blank">https://github.com/spawnthink/otp/compare/fix_mnesia_block_table_exception</a><br>
</div>
<div><a moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_mnesia_block_table_exception.patch"
target="_blank">https://github.com/spawnthink/otp/compare/fix_mnesia_block_table_exception.patch</a></div>
</div>
</div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra">
<br>
<br>
<div class="gmail_quote">On Thu, May 2, 2013 at 10:05
AM, Ahmed Omar <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:spawn.think@gmail.com"
target="_blank">spawn.think@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div dir="ltr"><span
style="font-size:12.727272033691406px;font-family:arial,sans-serif">Hello
Fredrik, </span>
<div
style="font-size:12.727272033691406px;font-family:arial,sans-serif">Could
you please refetch, I removed an extra call
to val(Var)</div>
<div
style="font-size:12.727272033691406px;font-family:arial,sans-serif"><a
moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_mnesia_block_table"
target="_blank">https://github.com/spawnthink/otp/compare/fix_mnesia_block_table</a></div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
<div>On Thu, May 2, 2013 at 9:12 AM, Fredrik <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:fredrik@erlang.org"
target="_blank">fredrik@erlang.org</a>></span>
wrote:<br>
</div>
<div>
<div>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>
<div> On 05/01/2013 03:49 PM, Ahmed
Omar wrote: </div>
</div>
<blockquote type="cite">
<div>
<div>
<div dir="ltr"><span
style="font-size:12.727272033691406px;font-family:arial,sans-serif">git
fetch git://</span><a
moz-do-not-send="true"
href="http://github.com/spawnthink/otp.git"
style="font-family:arial,sans-serif;font-size:12.727272033691406px"
target="_blank">github.com/spawnthink/otp.git</a><span
style="font-size:12.727272033691406px;font-family:arial,sans-serif"> </span><font
color="#000000" face="arial,
sans-serif">fix_mnesia_block_table</font><br
style="font-size:12.727272033691406px;font-family:arial,sans-serif">
<div
style="font-size:12.727272033691406px;font-family:arial,sans-serif"><br>
</div>
<div>
<div><font color="#000000"
face="arial, sans-serif">Fix
crash in
mnesia_controller due to
a function_clause
exception from
is_tab_blocked/1</font></div>
<div><font color="#000000"
face="arial, sans-serif"><br>
</font></div>
<div><font color="#000000"
face="arial, sans-serif">If
mnesia_controller:block_table/1
is called twice for same
table,</font></div>
<div><font color="#000000"
face="arial, sans-serif">the
new stored value of
{Tab, where_to_commit}
will be {blocked,
{blocked,List}}.</font></div>
<div><font color="#000000"
face="arial, sans-serif">This
will result in an
exception when calling
is_tab_blocked/1.</font></div>
<div><font color="#000000"
face="arial, sans-serif">mnesia_conttoller:block_table/1
should check if the
table is already
blocked.</font></div>
</div>
<div
style="font-size:12.727272033691406px;font-family:arial,sans-serif"><br>
</div>
<div><font color="#000000"
face="arial, sans-serif"><a
moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_mnesia_block_table.patch"
target="_blank">https://github.com/spawnthink/otp/compare/fix_mnesia_block_table.patch</a></font><br>
</div>
<div><font color="#000000"
face="arial, sans-serif"><a
moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_mnesia_block_table"
target="_blank">https://github.com/spawnthink/otp/compare/fix_mnesia_block_table</a></font><br>
</div>
<div> <font color="#000000"
face="arial, sans-serif"><br>
</font></div>
<div><font color="#000000"
face="arial, sans-serif">Best
Regards,</font></div>
<div><font color="#000000"
face="arial, sans-serif">Ahmed
Omar</font></div>
</div>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
erlang-patches mailing list
<a moz-do-not-send="true" href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a>
<a moz-do-not-send="true" href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
Hello Ahmed,<br>
I've fetched your patch and it is
currently in the 'pu' branch.<span><font
color="#888888"><br>
<br>
<pre cols="72">--
BR Fredrik Gustafsson
Erlang OTP Team</pre>
</font></span></div>
</blockquote>
</div>
</div>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
erlang-patches mailing list<br>
<a moz-do-not-send="true"
href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a><br>
<a moz-do-not-send="true"
href="http://erlang.org/mailman/listinfo/erlang-patches"
target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
/Henrik Nord Erlang/OTP</pre>
</body>
</html>