<div dir="ltr">This looks great, major improvement for larger orddicts, +1</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 2, 2013 at 3:02 AM, Steve Vinoski <span dir="ltr"><<a href="mailto:vinoski@ieee.org" target="_blank">vinoski@ieee.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I've added a new commit to this branch that addresses the concerns Anthony raised. Please refetch.<span class="HOEnZb"><font color="#888888"><div>
<br></div><div>--steve</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 30, 2013 at 5:32 AM, Steve Vinoski <span dir="ltr"><<a href="mailto:vinoski@ieee.org" target="_blank">vinoski@ieee.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Great feedback, Anthony -- thanks very much. Clearly there are more backward compatibility issues I need to address.<span><font color="#888888"><div>
<br></div><div>--steve</div></font></span></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Sep 30, 2013 at 4:00 AM, Anthony Ramine <span dir="ltr"><<a href="mailto:n.oxyde@gmail.com" target="_blank">n.oxyde@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello Steve,<br>
<br>
Great patch, I added a few comments about some edge cases.<br>
<br>
Regards,<br>
<br>
Le 30 sept. 2013 à 09:38, Steve Vinoski a écrit :<br>
<div><div><br>
> This patch improves the performance of some orddict functions by reimplementing them using the lists module:<br>
><br>
> <a href="https://github.com/erlang/otp/pull/91" target="_blank">https://github.com/erlang/otp/pull/91</a><br>
><br>
> The commit message at the link above is very detailed and includes performance measurements, so please read it to know more about the changes.<br>
><br>
> --steve<br>
</div></div>> _______________________________________________<br>
> erlang-patches mailing list<br>
> <a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a><br>
> <a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<span><font color="#888888"><br>
--<br>
Anthony Ramine<br>
<br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
erlang-patches mailing list<br>
<a href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>/* Sincerely<br>-------------------------------------------------------------- <br>Pedram Nimreezi - Chief Technology Officer */<div><br></div><div>// The hardest part of design … is keeping features out. - Donald Norman</div>
<div><br></div><div><br></div>
</div>