<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 13, 2013 at 4:43 PM, Sverker Eriksson <span dir="ltr"><<a href="mailto:sverker.eriksson@ericsson.com" target="_blank">sverker.eriksson@ericsson.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">Fredrik wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On 08/01/2013 07:40 AM, Yura Beznos wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hello,<br>
<br>
I'd like to submit this patch to add two new functions to the crypt<br>
library.<br>
<br>
Repo branch: <a href="https://github.com/Zhiz0id/otp/tree/aes_ige_crypt" target="_blank">https://github.com/Zhiz0id/<u></u>otp/tree/aes_ige_crypt</a><br>
Compare:<br>
<a href="https://github.com/Zhiz0id/otp/compare/erlang:master...aes_ige_crypt" target="_blank">https://github.com/Zhiz0id/<u></u>otp/compare/erlang:master...<u></u>aes_ige_crypt</a><br>
<br>
Why this new feature?<br>
<br>
It allows to use OpenSSL aes_ige_encrypt function.<br>
<br>
Risks / uncertain artifacts<br>
<br>
None.<br>
<br>
How did you solve it?<br>
<br>
Added two functions: aes_ige_256_decrypt, aes_ige_256_encrypt .<br>
<br>
<br>
Thanks.<br>
<br>
<br>
-- <br>
Yura<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
erlang-patches mailing list<br>
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/<u></u>listinfo/erlang-patches</a><br>
</blockquote>
Hello Yura,<br>
I've assigned this patch to be reviewed by responsible, you will get feedback as soon as this is done.<br>
Thanks,<br>
</blockquote>
<br></div></div>
Looks good, Yura. Two objections though:<br>
<br>
1. Do not export the aes_ige_256_encrypt/decrypt functions. Users should only use block_encrypt/4 and block_decrypt/4.<br>
<br>
2. Documentation updates is missing (of block_encrypt/4 and block_decrypt/4).<br>
<br>
<br>
/Sverker, Erlang/OTP<br>
<br>
</blockquote></div><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Compare url: <a href="https://github.com/Zhiz0id/otp/compare/erlang:master...aes_ige_crypt">https://github.com/Zhiz0id/otp/compare/erlang:master...aes_ige_crypt</a></div>
</div>