<div dir="ltr">Hi Vance, I have looked at your patch and discussed with my team and here is what we have so far:<div><br></div><div style>We do think that this type of functionality is interesting. We would, however, like to look at it in a bigger picture and possibly investigate the functionality for distributed applications a bit more before jumping to any conclusion. Would it be possible for you to provide us with some more information about the exact problem that you want to solve and maybe other use cases?</div>
<div style><br></div><div style>Any input and ideas from other readers of the list would of course also be very welcome :)</div><div style><br></div><div style>While reviewing, I also found that your patch is a bit incomplete as it does not introduce any new handling of #state.remote_started. This causes (at least) a hanging in the following scenario:</div>
<div style>1. Start all nodes in first group</div><div>2. On first node in first group: application:start(MyDistApp).</div><div>3. Start all nodes in second group</div><div>4. On first node in second group: application:start(MyDistApp).</div>
<div>5. On other node in first group: application:start(MyDistApp).</div><div>=> hangs, since #state.remote_started contains two elements and only the first (which by chance is not the correct one) is considered.</div>
<div><br></div><div style>- This is just for information, and I don't suggest that you spend a lot of time solving this, since we don't yet know if we will accept the patch or not.</div><div style><br></div><div style>
Best regards</div><div style>/siri@otp</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/5/8 Fredrik <span dir="ltr"><<a href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div class="im">
On 05/08/2013 03:30 PM, Vance Shipley wrote:
<blockquote type="cite">
<pre>On Tue, May 07, 2013 at 10:40:27AM +0200, Fredrik wrote:
} Your patch seems to fail some testcases, for certain I know that it
} is failing application_SUITE:distr_changed_tc2.
} And I have seen some indications that it is also is failing
} application_SUITE:script_start.
} Could you please look into this matter as I am removing it from pu
} until further notice from you.
Frederik,
I have pulled the pu branch, fetched my non_overlap_application_distribution
branch, built and run the application_SUITE test suite on my MacBook Pro
with the same results as before. The only case failing is otp_3002 which
failed before my changes.
I'll look at distr_changed_tc2 and try and reason why it might fail.
Any further information you can give me on the failure you saw would help.
What environment was it run on?
</pre>
</blockquote></div>
This happened on both linux and darwin.<br>
The testcases are not failing without your patch in pu so that was
the cause, I know that for certain.<br>
The script_start testcase is only failing on linux though.<br>
distr_changed_tc2 is failing with reason:<br>
<pre style="line-height:normal;text-indent:0px;letter-spacing:normal;text-align:-webkit-auto;font-variant:normal;text-transform:none;font-style:normal;font-size:0.8em;font-family:Monaco,'Andale Mono',Consolas,monospace;font-weight:normal;word-spacing:0px">
=== reason = {suite_failed,"distribution error: Cp2 [app2,app3,app6,app8,kernel,stdlib] "}
</pre>
And script_start with reason:<br>
<pre style="line-height:normal;text-indent:0px;letter-spacing:normal;text-align:-webkit-auto;font-variant:normal;text-transform:none;font-style:normal;font-size:0.8em;font-family:Monaco,'Andale Mono',Consolas,monospace;font-weight:normal;word-spacing:0px">
=== reason = {suite_failed,not_valid_start_type}</pre><div class="im">
<br>
<br>
<pre cols="72">--
BR Fredrik Gustafsson
Erlang OTP Team</pre>
</div></div>
<br>_______________________________________________<br>
erlang-patches mailing list<br>
<a href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<br></blockquote></div><br></div>