<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 05/09/2013 03:09 PM, Anthony Ramine wrote:
<blockquote
cite="mid:3EACB88F-B932-48D5-9C8C-BC5D9E235904@gmail.com"
type="cite">
<pre wrap="">Hello,
git fetch <a class="moz-txt-link-freetext" href="https://github.com/nox/otp.git">https://github.com/nox/otp.git</a> fix-ignore
<a class="moz-txt-link-freetext" href="https://github.com/nox/otp/compare/erlang:maint...fix-wcwidth">https://github.com/nox/otp/compare/erlang:maint...fix-wcwidth</a>
<a class="moz-txt-link-freetext" href="https://github.com/nox/otp/compare/erlang:maint...fix-wcwidth.patch">https://github.com/nox/otp/compare/erlang:maint...fix-wcwidth.patch</a>
Regards,
</pre>
</blockquote>
Hello Anthony,<br>
Some questions raised when reviewing your patch,<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">Isn't this already taken care of by
$ERL_TOP/.gitignore:</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">/lib/otp_mibs/include/[A-Z]*.hrl
/lib/os_mon/include/[A-Z]*.hrl</p>
What you want to achieve in your patch should be handled in this
gitignore.<br>
Thanks,<br>
<br>
<pre class="moz-signature" cols="72">--
BR Fredrik Gustafsson
Erlang OTP Team</pre>
</body>
</html>