<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 05/14/2013 01:03 PM, Björn Gustavsson wrote:
<blockquote
cite="mid:CA+yh78Ru8-RM9aCw_ogNL_HBjYfOjqngqb5jGz1QyBdezRC6SA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div style="">Clever surgery of prim_eval.beam!</div>
<div><br>
</div>
Looks good to me. Hidden like this, using BEAM
<div>assembly code is fine for me. From the outside,</div>
<div>prim_eval:'receive'/2 looks like any other BIF</div>
<div>(where BIF = "function implemented in C or Erlang</div>
<div>included with the run-time system").<br>
<div><br>
</div>
<div style="">We will now test your patch for several days in
our daily</div>
</div>
<div style="">
builds before graduating it.</div>
<div style=""><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Mon, May 13, 2013 at 9:15 PM,
Anthony Ramine <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:n.oxyde@gmail.com" target="_blank">n.oxyde@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Done.
Please refetch.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Anthony Ramine<br>
<br>
Le 13 mai 2013 à 16:50, Anthony Ramine a écrit :<br>
</font></span>
<div class="HOEnZb">
<div class="h5"><br>
> Hello Fredrik,<br>
><br>
> Fine with me but what about other files like
leex.erl in parsetools which is BSD licensed?<br>
><br>
> Regards,<br>
><br>
> --<br>
> Anthony Ramine<br>
><br>
> Le 13 mai 2013 à 16:38, Fredrik a écrit :<br>
><br>
>> On 05/06/2013 10:30 PM, Anthony Ramine wrote:<br>
>>> Hello,<br>
>>><br>
>>> Using the low-level BEAM instructions, we
can loop over each message in the process queue and
removes the first message that matches, without
receiving them all to later send them back to itself.<br>
>>><br>
>>> git fetch<br>
>>> <a moz-do-not-send="true"
href="https://github.com/nox/otp.git" target="_blank">https://github.com/nox/otp.git</a><br>
>>> erl_eval-receive<br>
>>><br>
>>><br>
>>> <a moz-do-not-send="true"
href="https://github.com/nox/otp/compare/erlang:maint...erl_eval-receive"
target="_blank">https://github.com/nox/otp/compare/erlang:maint...erl_eval-receive</a><br>
>>><br>
>>><br>
>>> <a moz-do-not-send="true"
href="https://github.com/nox/otp/compare/erlang:maint...erl_eval-receive.patch"
target="_blank">https://github.com/nox/otp/compare/erlang:maint...erl_eval-receive.patch</a><br>
>>><br>
>>><br>
>>> Regards,<br>
>>><br>
>>><br>
>> Hello Anthony,<br>
>> You need to remove your "own" copyright text in<br>
>> erts/preloaded/src/add_abstract_code<br>
>> erts/preloaded/src/prim_eval.S<br>
>> erts/preloaded/src/prim_eval.erl<br>
>><br>
>> And replace this with ordinary Ericsson
license.<br>
>><br>
>> Thanks,<br>
>> --<br>
>><br>
>> BR Fredrik Gustafsson<br>
>> Erlang OTP Team<br>
>><br>
><br>
<br>
_______________________________________________<br>
erlang-patches mailing list<br>
<a moz-do-not-send="true"
href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a><br>
<a moz-do-not-send="true"
href="http://erlang.org/mailman/listinfo/erlang-patches"
target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Björn Gustavsson, Erlang/OTP, Ericsson AB
</div>
</blockquote>
Hey Anthony,<br>
Your patch is failing <br>
create_script testcase in the reltool_server_SUITE in reltool
application.<br>
With reason:<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre style="color: rgb(0, 0, 0); font-family: Monaco, 'Andale Mono', Consolas, monospace; font-size: 0.8em; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">*WARNING* : Missing application sasl. Can not upgrade with this release
reltool_server_SUITE.erl(550): <error>
Not matching actual result was:
{diff,{expected,{preLoaded,[erl_prim_loader,erlang,erts_internal,init,
otp_ring0,prim_file,prim_inet,prim_zip,
zlib]}},
{actual,{preLoaded,[erl_prim_loader,erlang,erts_internal,init,
otp_ring0,prim_eval,prim_file,prim_inet,
prim_zip,zlib]}}}
Expected:
equal
=== Ended at 2013-05-17 05:23:37
=== location {reltool_server_SUITE,create_script}
=== reason = [{"reltool_server_SUITE.erl",550}]</error></pre>
<br>
Could you have a look at it?<br>
Thanks<br>
<br>
<pre class="moz-signature" cols="72">--
BR Fredrik Gustafsson
Erlang OTP Team</pre>
</body>
</html>