<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 04/18/2013 02:20 PM, Tomáš Janoušek wrote:
<blockquote cite="mid:20130418122057.GA20220@nomi.cz" type="cite">
<pre wrap="">Hello,
git fetch git://github.com/liskin/otp.git erl_pp_options
<a class="moz-txt-link-freetext" href="https://github.com/liskin/otp/compare/erl_pp_options">https://github.com/liskin/otp/compare/erl_pp_options</a>
<a class="moz-txt-link-freetext" href="https://github.com/liskin/otp/compare/erl_pp_options.patch">https://github.com/liskin/otp/compare/erl_pp_options.patch</a>
Regards,
</pre>
</blockquote>
Hello,<br>
Your patch has been into review and the feedback was:<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">Hi,</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">The patch is fine.</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">There are however no test cases. I think it is easier
if I create a ticket with your changes as a basis and add tests as
needed.</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">Thank you.</p>
Thank you for your contribution,<br>
<br>
<pre class="moz-signature" cols="72">--
BR Fredrik Gustafsson
Erlang OTP Team</pre>
</body>
</html>