<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Hello,<br>
    <br>
    I've just merged this into maint so it will be part of the R16B01
    release.<br>
    <br>
    Lukas<br>
    <br>
    <div class="moz-cite-prefix">On 22/04/13 17:46, Lukas Larsson wrote:<br>
    </div>
    <blockquote cite="mid:51755B73.50007@erlang.org" type="cite">
      <meta content="text/html; charset=ISO-8859-1"
        http-equiv="Content-Type">
      Hello,<br>
      <br>
      I added a commit with the other memcopy to your patch. It is now
      running in the nightly tests.<br>
      <br>
      Lukas<br>
      <br>
      <div class="moz-cite-prefix">On 22/04/13 13:15, Steve Vinoski
        wrote:<br>
      </div>
      <blockquote
cite="mid:CAO+zUOUv=x0a0Xh9QX=V0BieREYmMPSxBnvXDEN0BgttEwEfjw@mail.gmail.com"
        type="cite">
        <div dir="ltr">Hi Lukas and Sverker,
          <div><br>
          </div>
          <div>No, I wasn't hitting ctrl-H. I was just running some
            eunit tests (with [verbose]) in a shell and when the tests
            finished and the shell went to print the next prompt,
            valgrind reported this error.
            <div> <br>
            </div>
            <div>One of my Basho colleagues, though, says he has seen
              errors that seem related to this when hitting ctrl-D after
              a sequence of cursor movements on the shell command line,
              but I was never able to reproduce that. Perhaps he was
              hitting the problem Sverker refers to.</div>
            <div><br>
            </div>
            <div style="">If you want me to change the patch to fix the
              other memcpy, just let me know.</div>
            <div style=""><br>
            </div>
            <div style="">--steve</div>
            <div style=""><br>
            </div>
          </div>
        </div>
        <div class="gmail_extra"><br>
          <br>
          <div class="gmail_quote"> On Mon, Apr 22, 2013 at 4:53 AM,
            Sverker Eriksson <span dir="ltr"><<a
                moz-do-not-send="true"
                href="mailto:sverker.eriksson@ericsson.com"
                target="_blank">sverker.eriksson@ericsson.com</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex"> The
              other call to memcpy in the same function del_chars()
              seems to have the same problem.<br>
              Probably possible to trigger with ctrl-D.<br>
              <br>
              /Sverker<br>
              <br>
              Lukas Larsson wrote:<br>
              <blockquote class="gmail_quote" style="margin:0 0 0
                .8ex;border-left:1px #ccc solid;padding-left:1ex">
                <div class="im"> Hello Steve!<br>
                  <br>
                  Thanks for the patch.<br>
                  <br>
                  I had to use ctrl-H in the middle of a term in the
                  terminal to trigger the report, was this the case for
                  you as well?<br>
                  <br>
                  Lukas<br>
                  <br>
                  On 22/04/13 02:23, Steve Vinoski wrote:<br>
                </div>
                <blockquote class="gmail_quote" style="margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">
                  <div class="im"> On Linux I noticed the following
                    complaint while doing some valgrind testing:<br>
                    <br>
                    ==18040== Thread 6:<br>
                    ==18040== Source and destination overlap in
                    memcpy(0xf3f3f04, 0xf3f3f08, 52)<br>
                    ==18040==    at 0x4C2CFA0: <a
                      moz-do-not-send="true"
                      class="moz-txt-link-abbreviated"
                      href="mailto:memcpy@@GLIBC_2.14">memcpy@@GLIBC_2.14</a>
                    (in
                    /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)<br>
                    ==18040==    by 0x5CF527: del_chars (ttsl_drv.c:845)<br>
                    ==18040==    by 0x5CED5E: ttysl_from_erlang
                    (ttsl_drv.c:658)<br>
                    ==18040==    by 0x4982E3: erts_write_to_port
                    (io.c:1235)<br>
                    ==18040==    by 0x49A2BD: erts_port_command
                    (io.c:2223)<br>
                    ==18040==    by 0x48C054: do_send (bif.c:1962)<br>
                    ==18040==    by 0x48CB6E: erl_send (bif.c:2162)<br>
                    ==18040==    by 0x566599: process_main
                    (beam_emu.c:1665)<br>
                    ==18040==    by 0x4B1A95: sched_thread_func
                    (erl_process.c:4834)<br>
                    ==18040==    by 0x6075E2: thr_wrapper
                    (ethread.c:106)<br>
                    ==18040==    by 0x5560E99: start_thread
                    (pthread_create.c:308)<br>
                    <br>
                    This patch fixes the problem.<br>
                    <br>
                  </div>
                  git fetch git://<a moz-do-not-send="true"
                    href="http://github.com/vinoski/otp.git"
                    target="_blank">github.com/vinoski/otp.git</a> <<a
                    moz-do-not-send="true"
                    href="http://github.com/vinoski/otp.git"
                    target="_blank">http://github.com/vinoski/otp.git</a>>

                  sv-ttsl-valgrind
                  <div class="im"> <br>
                    <br>
                    <a moz-do-not-send="true"
href="https://github.com/vinoski/otp/compare/erlang:maint...sv-ttsl-valgrind"
                      target="_blank">https://github.com/vinoski/otp/compare/erlang:maint...sv-ttsl-valgrind</a><br>
                    <a moz-do-not-send="true"
href="https://github.com/vinoski/otp/compare/erlang:maint...sv-ttsl-valgrind.patch"
                      target="_blank">https://github.com/vinoski/otp/compare/erlang:maint...sv-ttsl-valgrind.patch</a>
                    <br>
                    <br>
                    --steve<br>
                    <br>
                    <br>
                    _______________________________________________<br>
                    erlang-patches mailing list<br>
                    <a moz-do-not-send="true"
                      href="mailto:erlang-patches@erlang.org"
                      target="_blank">erlang-patches@erlang.org</a><br>
                    <a moz-do-not-send="true"
                      href="http://erlang.org/mailman/listinfo/erlang-patches"
                      target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
                  </div>
                </blockquote>
                <br>
                <br>
                ------------------------------------------------------------------------

                <div class="im"><br>
                  <br>
                  _______________________________________________<br>
                  erlang-patches mailing list<br>
                  <a moz-do-not-send="true"
                    href="mailto:erlang-patches@erlang.org"
                    target="_blank">erlang-patches@erlang.org</a><br>
                  <a moz-do-not-send="true"
                    href="http://erlang.org/mailman/listinfo/erlang-patches"
                    target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
                    <br>
                </div>
              </blockquote>
              <div class="HOEnZb">
                <div class="h5"> <br>
                  _______________________________________________<br>
                  erlang-patches mailing list<br>
                  <a moz-do-not-send="true"
                    href="mailto:erlang-patches@erlang.org"
                    target="_blank">erlang-patches@erlang.org</a><br>
                  <a moz-do-not-send="true"
                    href="http://erlang.org/mailman/listinfo/erlang-patches"
                    target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
                </div>
              </div>
            </blockquote>
          </div>
          <br>
        </div>
      </blockquote>
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>