<div dir="ltr">Ok, thanks. This syntax is not described in the how-to, and it should probably be, because it's easier to not forget to update the default branch at github<div><br></div><div style>I updated the wiki with the following:</div>
<div style><br></div><div style><div>Additionally include the following two links for viewing the changes:</div><div><pre><br></div><div><a href="https://github.com/mygithub/otp/compare/erlang:BASE...my-cool-updates">https://github.com/mygithub/otp/compare/erlang:BASE...my-cool-updates</a></div>
<div><a href="https://github.com/mygithub/otp/compare/erlang:BASE...my-cool-updates.patch">https://github.com/mygithub/otp/compare/erlang:BASE...my-cool-updates.patch</a></div><div></pre></div><div>where BASE should be the base branch, @maint@ or @master@.<br>
</div><div><br></div></div><div>/Vlad<br></div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Feb 1, 2013 at 11:44 AM, Fredrik <span dir="ltr"><<a href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div><div class="h5">
On 02/01/2013 11:37 AM, Vlad Dumitrescu wrote:
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>It already is on master (but I just had some git issues, so
you might have to refetch).</div>
<div><br>
</div>
<div>/Vlad</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
On Fri, Feb 1, 2013 at 11:24 AM, Fredrik <span dir="ltr"><<a href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>On 02/01/2013 11:13 AM, Nico Kruber wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Friday 01 Feb 2013 09:58:54 Vlad Dumitrescu wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi!<br>
<br>
I found a small problem in jinterface. It has been
around for a while now,<br>
it happens in a corner case that probably nobody
ever uses.<br>
<br>
In OtpErlangTuple(OtpErlangObject[], int, int), when
the size of the slice<br>
used is 0, then the elems fields remains
uninitialized, it is the parameter<br>
that gets assigned.<br>
<br>
I used master as base, I hope it's still possible to
do that.<br>
<br>
git fetch git://<a href="http://github.com/vladdu/otp.git" target="_blank">github.com/vladdu/otp.git</a>
tuple_constructor_bug<br>
<br>
<a href="https://github.com/vladdu/otp/compare/tuple_constructor_bug" target="_blank">https://github.com/vladdu/otp/compare/tuple_constructor_bug</a><br>
<a href="https://github.com/vladdu/otp/compare/tuple_constructor_bug.patch" target="_blank">https://github.com/vladdu/otp/compare/tuple_constructor_bug.patch</a><br>
<br>
Given that there are no other tests for jinterface
at this level, do you<br>
want me to write one for this case?<br>
<br>
best regards,<br>
Vlad<br>
</blockquote>
your branch is outdated so the diff is not clean, i.e.
contains a lot of other<br>
commits<br>
-> please rebase your branch<br>
see <a href="https://github.com/erlang/otp/wiki/Submitting-patches" target="_blank">https://github.com/erlang/otp/wiki/Submitting-patches</a><br>
<br>
it would probably also be good to base it on maint -
but someone from the otp<br>
team needs to decide here :)<br>
<br>
your commit though seems reasonable<br>
<a href="https://github.com/vladdu/otp/commit/ee29a8aa733fbf1a1666b2f85a9fd6ff19d777b3" target="_blank">https://github.com/vladdu/otp/commit/ee29a8aa733fbf1a1666b2f85a9fd6ff19d777b3</a><br>
<br>
<br>
Nico<br>
_______________________________________________<br>
erlang-patches mailing list<br>
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
</blockquote>
</div>
</div>
Hello,<br>
Just rebase it on master will work fine for me.<span><font color="#888888"><br>
<br>
-- <br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team</font></span>
<div>
<div><br>
<br>
_______________________________________________<br>
erlang-patches mailing list<br>
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote></div></div>
Re-fetched the patch, I don't remember how the how-to is describing
on the comparison-links but you should write it like this instead
<a href="https://github.com/vladdu/otp/compare/erlang:master...tuple_constructor_bug" target="_blank">https://github.com/vladdu/otp/compare/erlang:master...tuple_constructor_bug</a><br>
So,<br>
the branch you are based upon should be in the link
('erlang:master...' or when it is maint 'erlang:maint...').<br>
This will make a proper link for us to examine.<div class="im"><br>
<br>
<pre cols="72">--
BR Fredrik Gustafsson
Erlang OTP Team</pre>
</div></div>
</blockquote></div><br></div>