Hello OTP team, congratulations on the release!<div><br></div><div>I have noticed that the cover bug fixes were not included in R16A.</div><div><br></div><div>Is there something pending that I could do?</div><div><br></div>
<div>Thank you,<br clear="all"><div><div><br></div><div><br></div><div><span style="font-size:13px"><div><span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><b>José Valim</b></span></div><div>
<span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><div><span style="font-family:verdana,sans-serif;font-size:x-small"><a href="http://www.plataformatec.com.br/" style="color:rgb(42,93,176)" target="_blank">www.plataformatec.com.br</a></span></div>
<div><span style="font-family:verdana,sans-serif;font-size:x-small">Skype: jv.ptec</span></div><div><span style="font-family:verdana,sans-serif;font-size:x-small">Founder and Lead Developer</span></div></span></div></span></div>
</div>
<br><br><div class="gmail_quote">On Thu, Jan 10, 2013 at 3:08 AM, Fredrik <span dir="ltr"><<a href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Great, I'll re-fetch this.<br>
Thanks for your contribution!<div class="im"><br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br></div><div><div class="h5">
On 01/10/2013 11:04 AM, José Valim wrote:
<blockquote type="cite">
<div style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif">Anyway,
here are the patches without ?line.</div>
<div style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif"><br>
</div>
<div style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif">git
fetch git://<a href="http://github.com/josevalim/otp.git" style="color:rgb(17,85,204)" target="_blank">github.com/josevalim/otp.git</a> cover-patches-no-line</div>
<div style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif"><br>
</div>
<div style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif"><a href="https://github.com/josevalim/otp/compare/cover-patches-no-line" style="color:rgb(17,85,204)" target="_blank">https://github.com/josevalim/otp/compare/cover-patches-no-line</a></div>
<div style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif"><a href="https://github.com/josevalim/otp/compare/cover-patches-no-line.patch" style="color:rgb(17,85,204)" target="_blank">https://github.com/josevalim/otp/compare/cover-patches-no-line.patch</a></div>
<div>
<div><br>
</div>
<div><br>
</div>
<div><span style="font-size:13px">
<div><span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><b>José
Valim</b></span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">
<div>
<span style="font-family:verdana,sans-serif;font-size:x-small"><a href="http://www.plataformatec.com.br/" style="color:rgb(42,93,176)" target="_blank">www.plataformatec.com.br</a></span></div>
<div><span style="font-family:verdana,sans-serif;font-size:x-small">Skype:
jv.ptec</span></div>
<div><span style="font-family:verdana,sans-serif;font-size:x-small">Founder
and Lead Developer</span></div>
</span></div>
</span></div>
</div>
<br>
<br>
<div class="gmail_quote">On Thu, Jan 10, 2013 at 10:53 AM, José
Valim <span dir="ltr"><<a href="mailto:jose.valim@plataformatec.com.br" target="_blank">jose.valim@plataformatec.com.br</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I have added
?line to keep consistent with the remaining of the test file.
Do you want me to go ahead and remove ?line from the whole <i>lib/tools/test/cover_SUITE.erl</i> file
or this is something you have already done internally and I
should remove just the ones in my patch?
<div>
<br clear="all">
<div>
<div><br>
</div>
<div><br>
</div>
<div><span style="font-size:13px">
<div><span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><b>José
Valim</b></span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">
<div>
<span style="font-family:verdana,sans-serif;font-size:x-small"><a href="http://www.plataformatec.com.br/" style="color:rgb(42,93,176)" target="_blank">www.plataformatec.com.br</a></span></div>
<div><span style="font-family:verdana,sans-serif;font-size:x-small">Skype:
jv.ptec</span></div>
<div><span style="font-family:verdana,sans-serif;font-size:x-small">Founder
and Lead Developer</span></div>
</span></div>
</span></div>
</div>
<br>
<br>
</div>
<div>
<div>
<div class="gmail_quote">On Thu, Jan 10, 2013 at 10:45 AM,
Fredrik <span dir="ltr"><<a href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello,<br>
Your patch has been into review and the feedback you
got back was that everything looks good but you have
to remove the '?line' macros, because they are not
used and thus has no effect anymore.<br>
Please fix this and give me a notice when it is done<br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team
<div><br>
On 11/28/2012 02:11 PM, José Valim wrote: </div>
<blockquote type="cite">
<div>
<div>
<div>Hello,</div>
<div><br>
</div>
<div>I am sending a couple bug fixes for
cover.</div>
<div><br>
</div>
<div>I have broken those fixes into three
granular commits.</div>
<div>The commit messages contains the
rationale behind them.</div>
<div><br>
</div>
<div>One of the commits changes cover to get
the source from</div>
<div>"Module:module_info(compile)" if the
current heuristic that</div>
<div>traverses directories fails. In my
opinion, we could rely</div>
<div>solely on the source information and
remove the heuristic</div>
<div>completely but I have kept the current
heuristic as the first</div>
<div>mechanism in order to minimize the impact
of the changes.</div>
<div><br>
</div>
<div>As such, I would appreciate if those
changes could be merged</div>
<div>into maint. :)</div>
<div><br>
</div>
<div>git fetch git://<a href="http://github.com/josevalim/otp.git" target="_blank">github.com/josevalim/otp.git</a>
cover-patches</div>
<div><br>
</div>
<div><a href="https://github.com/josevalim/otp/compare/cover-patches" target="_blank">https://github.com/josevalim/otp/compare/cover-patches</a></div>
<div><a href="https://github.com/josevalim/otp/compare/cover-patches.patch" target="_blank">https://github.com/josevalim/otp/compare/cover-patches.patch</a></div>
<div><br>
</div>
<div>Thank you,</div>
<div><br>
</div>
<div><br>
</div>
<div><span style="font-size:13px">
<div><span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><b>José
Valim</b></span></div>
<div> <span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">
<div><span style="font-family:verdana,sans-serif;font-size:x-small"><a href="http://www.plataformatec.com.br/" style="color:rgb(42,93,176)" target="_blank">www.plataformatec.com.br</a></span></div>
<div><span style="font-family:verdana,sans-serif;font-size:x-small">Skype:
jv.ptec</span></div>
<div><span style="font-family:verdana,sans-serif;font-size:x-small">Founder
and Lead Developer</span></div>
</span></div>
</span></div>
<br>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
erlang-patches mailing list
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</div>
<br>
_______________________________________________<br>
erlang-patches mailing list<br>
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>