<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
It was not the bootstrap, I think you have to take a look at those
testcases,<br>
Here's the reason's:<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<span style="color: rgb(255, 255, 255); font-family: Monaco, 'Andale
Mono', Consolas, monospace; font-size: 13px; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: 2; text-align: -webkit-auto;
text-indent: 0px; text-transform: none; white-space: pre; widows:
2; word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; background-color: rgb(204, 0, 0);
display: inline !important; float: none; ">compilation_SUITE:self_compile_1
failed on line 428
Reason: suite_failed<br>
<br>
</span>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<span style="color: rgb(255, 255, 255); font-family: Monaco,'Andale
Mono',Consolas,monospace; font-size: 13px; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: 2; text-indent: 0px; text-transform:
none; white-space: pre; widows: 2; word-spacing: 0px;
background-color: rgb(204, 0, 0); display: inline ! important;
float: none;">inline_SUITE:try_inline failed on line 117
Reason: {badmatch,error}<br>
<br>
</span>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<span style="color: rgb(255, 255, 255); font-family: Monaco, 'Andale
Mono', Consolas, monospace; font-size: 13px; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: 2; text-align: -webkit-auto;
text-indent: 0px; text-transform: none; white-space: pre; widows:
2; word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; background-color: rgb(204, 0, 0);
display: inline !important; float: none; ">inline_SUITE:try_inline
failed on line 117
Reason: {badmatch,error}</span><br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 01/16/2013 12:02 PM, Anthony Ramine wrote:
<blockquote
cite="mid:5E4FC9A7-A6C1-44AE-A217-987DD7782D1D@gmail.com"
type="cite">
<pre wrap="">I can't reproduce any of these failures.
Could I have more informations about how they failed?
My wild guess is that it is related (maybe) to the bootstrap compiler,
but I'm probably wrong.
Björn, any idea?
Regards,
<div class="moz-txt-sig">--
Anthony Ramine
Le 16 janv. 2013 à 11:46, Fredrik a écrit :
</div></pre>
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">> </span>Hello Anthony,
<span class="moz-txt-citetags">> </span>Your patch is failing the following testsuites and testcases:
<span class="moz-txt-citetags">> </span>compilation_SUITE : self_compile
<span class="moz-txt-citetags">> </span>inline_SUITE : decode1
<span class="moz-txt-citetags">> </span>inline_SUITE : pseudoknot
<span class="moz-txt-citetags">> </span>
<span class="moz-txt-citetags">> </span>Please correct and give me notice,
<span class="moz-txt-citetags">> </span>
<span class="moz-txt-citetags">> </span>BR Fredrik Gustafsson
<span class="moz-txt-citetags">> </span>Erlang OTP Team
<span class="moz-txt-citetags">> </span>On 01/15/2013 11:40 AM, Fredrik wrote:
</pre>
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>> </span>Hello Anthony <span class="moz-smiley-s3" title=";)"><span>;)</span></span>
<span class="moz-txt-citetags">>> </span>It is now in the 'master-pu' branch.
<span class="moz-txt-citetags">>> </span>Thanks,
<span class="moz-txt-citetags">>> </span>
<span class="moz-txt-citetags">>> </span>BR Fredrik Gustafsson
<span class="moz-txt-citetags">>> </span>Erlang OTP Team
<span class="moz-txt-citetags">>> </span>On 01/15/2013 11:28 AM, Anthony Ramine wrote:
</pre>
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>> </span>Repost on only erlang-patches so that Fredrik's MUA see it;)
<span class="moz-txt-citetags">>>> </span>
<span class="moz-txt-citetags">>>> </span>-- Anthony Ramine Début du message réexpédié :
</pre>
<blockquote type="cite" style="color: #000000;">
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>> > </span> De : Anthony Ramine<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:n.oxyde@gmail.com"><n.oxyde@gmail.com></a>
<span class="moz-txt-citetags">>>>> > </span> Objet : Rép : Local function names in Core Erlang guards
<span class="moz-txt-citetags">>>>> > </span> Date : 11 janvier 2013 17:12:37 HNEC
<span class="moz-txt-citetags">>>>> > </span> À : erlang-bugs Bugs<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:erlang-bugs@erlang.org"><erlang-bugs@erlang.org></a>, erlang patches<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:erlang-patches@erlang.org"><erlang-patches@erlang.org></a>
<span class="moz-txt-citetags">>>>> > </span> Cc : Bjorn Gustavsson<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:bjorn@erlang.org"><bjorn@erlang.org></a>
</pre>
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>> > > </span> Hi,
<span class="moz-txt-citetags">>>>> > > </span> I wrote a really small patch to forbid local fun variables in Core Erlang guards.
</pre>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>> > </span> There is no test case as there is no test suite for core_lint.
</pre>
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>> > > </span> I know the code freeze for R16 is soon but this is really a very small thing.
<span class="moz-txt-citetags">>>>> > > </span> git fetchhttps://github.com/nox/otp.git forbid-locals-in-core-guards
<span class="moz-txt-citetags">>>>> > > </span> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://github.com/nox/otp/compare/erlang:master...forbid-locals-in-core-guards">https://github.com/nox/otp/compare/erlang:master...forbid-locals-in-core-guards</a>
</pre>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>> > </span> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://github.com/nox/otp/compare/erlang:master...forbid-locals-in-core-guards.patch">https://github.com/nox/otp/compare/erlang:master...forbid-locals-in-core-guards.patch</a>
</pre>
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>> > > </span> Regards,
<span class="moz-txt-citetags">>>>> > > </span> -- > Anthony Ramine
<span class="moz-txt-citetags">>>>> > > </span> Le 19 nov. 2012 à 11:02, Anthony Ramine a écrit :
</pre>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>> ></span>
</pre>
<blockquote type="cite" style="color: #000000;">
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> </span> Hi,
</pre>
<blockquote type="cite" style="color: #000000;">
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> >> </span> While patching the compiler to allow substitutions of variables which values are
</pre>
</blockquote>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> </span> local function names [1], I discovered that core_lint doesn't forbid them in guards,
<span class="moz-txt-citetags">>>>>> >> </span> even though that makes the compiler passes further down the road generate badly-formed
<span class="moz-txt-citetags">>>>>> >> </span> BEAM code.
</pre>
<blockquote type="cite" style="color: #000000;">
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> >> </span> Is that a bug in core_lint or a bug in the BEAM code generation? Should local function
</pre>
</blockquote>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> </span> names be allowed in guards?
</pre>
<blockquote type="cite" style="color: #000000;">
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> >> </span> If it is a bug in core_lint, I can make a patch for that; if it is a bug in the BEAM
</pre>
</blockquote>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> </span> code generation I would love to fix it and remove the code I wrote to avoid the
<span class="moz-txt-citetags">>>>>> >> </span> substitution in guards... but I lack knowledge about the BEAM innards.
</pre>
<blockquote type="cite" style="color: #000000;">
<blockquote type="cite" style="color: #000000;">
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> >> </span> Regards,
<span class="moz-txt-citetags">>>>>> >> >> </span> [1]<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://erlang.org/pipermail/erlang-patches/2012-November/003137.html">http://erlang.org/pipermail/erlang-patches/2012-November/003137.html</a>
<span class="moz-txt-citetags">>>>>> >> >> </span> -- >> Anthony Ramine
</pre>
</blockquote>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>>> >> </span>
</pre>
</blockquote>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>>>> > </span>
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>> </span>
<span class="moz-txt-citetags">>> </span>_______________________________________________
<span class="moz-txt-citetags">>> </span>erlang-patches mailing list
<span class="moz-txt-citetags">>> </span><a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<span class="moz-txt-citetags">>> </span><a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">> </span>
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>