<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
Your patch is introducing failure in following, test suite and
testcase:<br>
otp_SUITE, undefined_functions<br>
With reason:<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<pre style="color: rgb(0, 0, 0); font-family: Monaco, 'Andale Mono', Consolas, monospace; font-size: 0.8em; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">[syntax_tools]erl_prettypr:lay_2/2 calls undefined erl_syntax:query_expr_body/1</pre>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 01/11/2013 10:59 PM, Loïc Hoguin wrote:
<blockquote cite="mid:50F08B43.9010409@ninenines.eu" type="cite">Please
refetch.
<br>
<br>
On 01/10/2013 10:21 AM, Fredrik wrote:
<br>
<blockquote type="cite">Hello,
<br>
Could you please rebase this on the current 'master' branch and
fix the
<br>
problems it is facing.
<br>
<br>
BR Fredrik Gustafsson
<br>
Erlang OTP Team
<br>
On 12/17/2012 07:47 PM, Loïc Hoguin wrote:
<br>
<blockquote type="cite">On 11/28/2012 08:06 PM, Loïc Hoguin
wrote:
<br>
<blockquote type="cite"> git fetch
git://github.com/essen/otp.git forget-mnemosyne
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne">https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne</a>
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne.patch">https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne.patch</a>
<br>
<br>
</blockquote>
<br>
Please refetch. Amended the last commit with the proper fixes.
Tests
<br>
should pass and warning introduced has been removed.
<br>
<br>
Issue came from this:
<br>
% gg -i mnemosyne
<br>
src/mnesia.erl:119: %% Mnemosyne exclusive
<br>
src/mnesia.erl:2885:%% Mnemosyne exclusive
<br>
<br>
Which says it's Mnemosyne exclusive but is clearly not as it's
used by
<br>
a few tests. I'll leave this for someone with better Mnesia
knowledge
<br>
to decide what to do.
<br>
<br>
Thanks!
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</body>
</html>