<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
I don't see a reply on this, but I am happy to tell you that this
patch was merged to master the 13th of December!<br>
Thanks for your contribution!<br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 11/04/2012 03:54 PM, Thomas Järvstrand wrote:
<blockquote
cite="mid:CALbb2wGrn67Z7EEYeCoFAJtq+-XHVq2CxQ2qwCuy1gKa=q3jcw@mail.gmail.com"
type="cite">Hi!<br>
<br>
<a class="moz-txt-link-freetext" href="file:path_open/3">file:path_open/3</a> currently doesn't handle eisdir or enotdir return
values from <a class="moz-txt-link-freetext" href="file:open/2">file:open/2</a>. Suppose we want to do path_open(["dir1",
"dir2"], "sub/file") and dir2/sub/file is the actual path of the
file that we are looking for. The effect of not handling these
error cases is that the call will fail if dir1 happens to contain
either a regular file called sub (<a class="moz-txt-link-freetext" href="file:open/2">file:open/2</a> returns enotdir) or
a directory sub that in turn contains a directory file
(<a class="moz-txt-link-freetext" href="file:open/2">file:open/2</a> return eisdir).<br>
<br>
This patch handles these extra error cases in <a class="moz-txt-link-freetext" href="file:path_open/3">file:path_open/3</a><br>
<br>
Repo:<br>
git fetch <a class="moz-txt-link-abbreviated" href="mailto:git@github.com:tjarvstrand/otp.git">git@github.com:tjarvstrand/otp.git</a>
additional-error-cases-in-path_open<br>
<div id=":ch">
<br>
Comparison:<br>
<a moz-do-not-send="true"
href="https://github.com/tjarvstrand/otp/compare/additional-error-cases-in-path_open">https://github.com/tjarvstrand/otp/compare/additional-error-cases-in-path_open</a><br>
<a moz-do-not-send="true"
href="https://github.com/tjarvstrand/otp/compare/additional-error-cases-in-path_open.patch">https://github.com/tjarvstrand/otp/compare/additional-error-cases-in-path_open.patch</a><br>
<br>
Regards<br>
Thomas Järvstrand<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</body>
</html>