<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 2013-01-09 18:59, Yurii Rashkovskii
wrote:<br>
</div>
<blockquote
cite="mid:CA+RLCQxoZi0NE-D2_00489RPCz8K3FgbQdyo3U17kjWcEf8d=g@mail.gmail.com"
type="cite">
<div dir="ltr">While we are at it, would the OTP team considering
merging a patch that adds isatty functionality to Erlang, in
relation to this ANSI improvement?
<div><br>
</div>
<div>It would allow developers to print ANSI sequences only when
the program is using an actual terminal.</div>
</div>
</blockquote>
<br>
We would certainly review it but I have no other thoughts on the
matter right now. It seems like a good thing to do.<br>
<br>
We are getting pressed for time. Code freeze for R16A is 23/1 and we
have a lot of other things that needs to get done. If you have a
patch ready - send it. Nothing to lose. I can't guarantee we have
the time to review it though, depends on complexity =)<br>
<br>
// Björn-Egil<br>
<br>
<blockquote
cite="mid:CA+RLCQxoZi0NE-D2_00489RPCz8K3FgbQdyo3U17kjWcEf8d=g@mail.gmail.com"
type="cite">
<div dir="ltr">
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Jan 9, 2013 at 8:38 AM,
Björn-Egil Dahlberg <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:wallentin.dahlberg@gmail.com" target="_blank">wallentin.dahlberg@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I have
placed this patch into opu - i.e. a final integration test
through our daily builds.
<div><br>
</div>
<div>I've reconsidered its impact. It should not have any
impact if you don't use control sequences, which probably
is the case in legacy code since those were filtered
anyways. I also agree that not resetting the console is a
user error.</div>
<div><br>
</div>
<div>An easy way to reset the console if problems arise
might be a nice future addition though.</div>
<div><br>
</div>
<div>Your patch will probably be merged later this week if
it passes final integration, shouldn't be a problem
though.</div>
<span class="HOEnZb"><font color="#888888">
<div><br>
</div>
<div>// Björn-Egil</div>
</font></span>
<div class="HOEnZb">
<div class="h5">
<div><br>
<div class="gmail_quote">2012/12/18 Pedram Nimreezi <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:mc@majorcomputing.com"
target="_blank">mc@majorcomputing.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Yes that was intentionally omitted, as a small
percentage of the time<br>
it affected the ( ) brace matching (in smaller
terminals)..<br>
Also not properly resetting ANSI colors once a
color is set is<br>
technically a user error.<br>
Would agree always resetting is the way to go, if
it doesn't affect<br>
anything else.<br>
<div>
<div><br>
On Tue, Dec 18, 2012 at 9:36 AM, Björn-Egil
Dahlberg<br>
<<a moz-do-not-send="true"
href="mailto:wallentin.dahlberg@gmail.com"
target="_blank">wallentin.dahlberg@gmail.com</a>>
wrote:<br>
> This seems nice.<br>
><br>
> I use colors directly in the bash shell
normally. Also via Erlang. Could be<br>
> nice with colors in erlang shell also.
Seems more modern =)<br>
><br>
> Is:<br>
> --- a/lib/stdlib/src/shell.erl 2011-11-22
08:57:01.000000000 -0500<br>
> +++ b/lib/stdlib/src/shell.erl 2011-12-10
14:25:58.000000000 -0500<br>
> @@ -674,6 +674,7 @@ exprs([E0|Es], Bs1,
RT, Lf, Ef, Bs0, W)<br>
>
[io:requests([{put_chars, VS}, nl]) || W =:=
cmd],<br>
> %% Don't send the
result back if it will be<br>
> %% discarded anyway.<br>
> + io:fwrite("\e[0m"),<br>
> V = if<br>
> W =:= pmt
-><br>
> {W,V0};<br>
><br>
> intentionally omitted?<br>
> Always clearing the shell might be the
way to go =)<br>
><br>
> // Björn-Egil<br>
><br>
> 2012/11/22 Henrik Nord <<a
moz-do-not-send="true"
href="mailto:henrik@erlang.org"
target="_blank">henrik@erlang.org</a>><br>
>><br>
>> This mailing list + github is the
only way atm.<br>
>><br>
>> We are considering letting a view of
our daily build result page show up<br>
>> to the public via <a
moz-do-not-send="true"
href="http://erlang.org" target="_blank">erlang.org</a><br>
>> That would increase transparency and
possible decrease the turnaround time<br>
>> for patches as the authors themselves
could check the test results of their<br>
>> patches.<br>
>><br>
>><br>
>> On 2012-11-22 10:11, Yurii
Rashkovskii wrote:<br>
>><br>
>> Is there any *reliable* way to track
what's in pu/master-pu?<br>
>><br>
>><br>
>> On Thu, Nov 22, 2012 at 1:07 AM,
Henrik Nord <<a moz-do-not-send="true"
href="mailto:henrik@erlang.org"
target="_blank">henrik@erlang.org</a>>
wrote:<br>
>>><br>
>>> No its in there, it was just
removed temporary from the push<br>
>>><br>
>>><br>
>>><br>
>>> On 2012-11-21 19:01, Yurii
Rashkovskii wrote:<br>
>>><br>
>>> Forgive me if I am missing
something, but did this patch somehow not make<br>
>>> it to master-pu?<br>
>>><br>
>>><br>
>>> <a moz-do-not-send="true"
href="https://github.com/erlang/otp/blob/master-pu/erts/emulator/drivers/unix/ttsl_drv.c#L915"
target="_blank">https://github.com/erlang/otp/blob/master-pu/erts/emulator/drivers/unix/ttsl_drv.c#L915</a><br>
>>><br>
>>> (pu doesn't have it either<br>
>>> <a moz-do-not-send="true"
href="https://github.com/erlang/otp/blob/pu/erts/emulator/drivers/unix/ttsl_drv.c#L915"
target="_blank">https://github.com/erlang/otp/blob/pu/erts/emulator/drivers/unix/ttsl_drv.c#L915</a>)<br>
>>><br>
>>> Is it intentional or is it an
omission?<br>
>>><br>
>>><br>
>>> On Thu, Nov 15, 2012 at 4:20 AM,
Henrik Nord <<a moz-do-not-send="true"
href="mailto:henrik@erlang.org"
target="_blank">henrik@erlang.org</a>>
wrote:<br>
>>>><br>
>>>> Thank you for your
contribution, I have added the patch to
'master-pu'<br>
>>>><br>
>>>><br>
>>>><br>
>>>> On 2012-11-14 14:49, Pedram
Nimreezi wrote:<br>
>>>>><br>
>>>>><br>
>>>>> <a
moz-do-not-send="true"
href="https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L901"
target="_blank">https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L901</a><br>
>>>>><br>
>>>>> <a
moz-do-not-send="true"
href="https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L599"
target="_blank">https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L599</a><br>
>>>>><br>
>>>>> <a
moz-do-not-send="true"
href="https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L609"
target="_blank">https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L609</a><br>
>>>><br>
>>>><br>
>>>> --<br>
>>>> /Henrik Nord Erlang/OTP<br>
>>>><br>
>>>><br>
>>>>
_______________________________________________<br>
>>>> erlang-patches mailing list<br>
>>>> <a moz-do-not-send="true"
href="mailto:erlang-patches@erlang.org"
target="_blank">erlang-patches@erlang.org</a><br>
>>>> <a moz-do-not-send="true"
href="http://erlang.org/mailman/listinfo/erlang-patches"
target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> /Henrik Nord Erlang/OTP<br>
>><br>
>><br>
>><br>
>> --<br>
>> /Henrik Nord Erlang/OTP<br>
>><br>
>><br>
>>
_______________________________________________<br>
>> erlang-patches mailing list<br>
>> <a moz-do-not-send="true"
href="mailto:erlang-patches@erlang.org"
target="_blank">erlang-patches@erlang.org</a><br>
>> <a moz-do-not-send="true"
href="http://erlang.org/mailman/listinfo/erlang-patches"
target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
>><br>
><br>
><br>
>
_______________________________________________<br>
> erlang-patches mailing list<br>
> <a moz-do-not-send="true"
href="mailto:erlang-patches@erlang.org"
target="_blank">erlang-patches@erlang.org</a><br>
> <a moz-do-not-send="true"
href="http://erlang.org/mailman/listinfo/erlang-patches"
target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
><br>
<br>
<br>
<br>
--<br>
</div>
</div>
<div>
<div>/* Sincerely<br>
--------------------------------------------------------------<br>
Pedram Nimreezi - Chief Technology Officer */<br>
<br>
// The hardest part of design … is keeping
features out. - Donald Norman<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
erlang-patches mailing list<br>
<a moz-do-not-send="true"
href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a><br>
<a moz-do-not-send="true"
href="http://erlang.org/mailman/listinfo/erlang-patches"
target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</body>
</html>