<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Andreas,<br>
Your patch has finally been into review and the response was:<br>
"
<div class="application-body markdown">
<ul>
<li>The patch introduces new API options without documenting
them.</li>
<li>The patch introduces new include file ssl_srp.hrl that I
think shall be internal and put in src. It is undesirable to
have records in the user API as it makes the user application
compile time dependent on our code, better to use a proplist
and then create the record internally. (Yes "sslsocket" is a
record due to legacy)</li>
<li>The patch introduces new include file ssl_srp_primes.hrl
I think it feels better to input such values as atoms and
internaly uses the macros defined in this file, that would be
more consistent with the rest of the API. </li>
<li>Functions in crypto being named TLS something seems a little
strange,
is this necessary?!</li>
</ul>
</div>
"<br>
Please correct this and give me a notice when it is done.<br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 10/12/2012 11:38 AM, Henrik Nord wrote:
<blockquote cite="mid:5077E4FA.9060609@erlang.org" type="cite">refetching
<br>
<br>
On 10/12/2012 10:27 AM, Andreas Schultz wrote:
<br>
<blockquote type="cite">Hi Henrik,
<br>
<br>
When I rebased my changes to the current master, a change crept
in that
<br>
shouldn't have:
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/erlang/otp/commit/747ce9191f4dc7558e12e2b6e5696396392ffbd8">https://github.com/erlang/otp/commit/747ce9191f4dc7558e12e2b6e5696396392ffbd8</a>
<br>
<br>
I have removed it from my tree and pushed it.
<br>
<br>
Andreas
<br>
<br>
----- Original Message -----
<br>
<blockquote type="cite">Thanks, I will refetch!
<br>
On 10/11/2012 12:49 PM, Andreas Schultz wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
I have pushed a change that should fix the compile error.
The
<br>
buffer has
<br>
a fixed length now.
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/RoadRunnr/otp/commit/ad73b09d948d0414132bfca2f67ff0de729fa7b2">https://github.com/RoadRunnr/otp/commit/ad73b09d948d0414132bfca2f67ff0de729fa7b2</a>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/RoadRunnr/otp/commit/ad73b09d948d0414132bfca2f67ff0de729fa7b2.patch">https://github.com/RoadRunnr/otp/commit/ad73b09d948d0414132bfca2f67ff0de729fa7b2.patch</a>
<br>
<br>
Andreas
<br>
<br>
----- Original Message -----
<br>
<blockquote type="cite">Does not compile on Windows.
<br>
<br>
Function SHA1_Update_PAD in crypto.c is not correct.
Arrays with
<br>
dynamic
<br>
size is not supported by the C standard we use.
<br>
Use a static array instead, presuming that there is a
reasonable
<br>
upper
<br>
limit of its size.
<br>
<br>
/Sverker, Erlang/OTP
<br>
<br>
<br>
<br>
Henrik Nord wrote:
<br>
<blockquote type="cite">Hi
<br>
<br>
I have added your branch to 'master'pu' for testing.
<br>
Thank you for your contribution!
<br>
<br>
On 10/04/2012 06:29 PM, Andreas Schultz wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Tree is rebased onto latest master.
<br>
<br>
Andreas
<br>
<br>
----- Original Message -----
<br>
<blockquote type="cite">Would you be so kind as to
rebase this branch upon the latest
<br>
'master'
<br>
<br>
Thank you for your contribution!
<br>
<br>
<br>
<br>
On 09/26/2012 07:19 PM, Andreas Schultz wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
I have implemented the more interesting parts of
RFC 4279, RFC
<br>
5487
<br>
and RFC 5054 (aka TLS PSK and SRP ciphers). The
use and
<br>
usefulness
<br>
of those ciphers is rather limited, the one
notable exception
<br>
being
<br>
the eID server protocol for German national
identity cards
<br>
(nPA).
<br>
<br>
The test suite can only verify some PSK suites
against openssl
<br>
as
<br>
currently no openssl version supports them all.
There is patch
<br>
that add some to openssl, but it has not been
incorporated
<br>
into
<br>
upstream. GNU-TLS implements some more (but not
all) PSK
<br>
suites
<br>
and I have manually tested interoperability.
<br>
<br>
Patch info:
<br>
<br>
git fetch git://github.com/RoadRunnr/otp.git
<br>
tls-psk-srp-suites
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites">https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites</a>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites.patch">https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites.patch</a>
<br>
<br>
Regards
<br>
Andreas
<br>
</blockquote>
--
<br>
/Henrik Nord Erlang/OTP
<br>
<br>
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
--
<br>
/Henrik Nord Erlang/OTP
<br>
<br>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>