<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Your patch has been into review and the feedback was:<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">Hi</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">We have decided to not include this patch, the lists
module is full :-) and we are now rather restrictive in what we
add to it.</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">The convenience functions you added are already
available with, array:foldl(Fun, [], array:from_list(List)) with
some more functionality such as foldr, map and so on. Also the
array module probably is a better datastructure to use if you need
to access by index.</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 9px;
margin-left: 0px; font-family: 'Helvetica Neue', Helvetica, Arial,
sans-serif; font-size: 13px; line-height: 18px; color: rgb(51, 51,
51); font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; background-color: rgb(249,
249, 249); ">Nice patch and sorry for the lost effort.</p>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 12/16/2012 06:57 AM, Jeremy Ong wrote:
<blockquote
cite="mid:CA+Jb5n6JczVZGF=iSL8gkp1noBCxb9=WuT8Er0SbkGEQ_jbGaw@mail.gmail.com"
type="cite">
<div>git fetch git://<a moz-do-not-send="true"
href="http://github.com/jeremyong/otp.git">github.com/jeremyong/otp.git</a>
lists_module_additions<br>
</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions">https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions</a><br>
</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions.patch">https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions.patch</a><br>
</div>
<div><br>
</div>
I have added a few convenience functions for operating on lists in
the stdlib.
<div><br>
</div>
<div>These functions are ifoldl, ifoldr, imap, ifilter, and
ipartition (the i stands for "index).</div>
<div><br>
</div>
<div>Often times, the index of an element is important when
transforming a list (for example, if I want to perform an
operation on an odd-indexed elements or tag each element of a
list with the index formatted in some way). These functions are
very similar to the usual ones but the lambdas passed to them
take an additional argument which is the index of each element
as it gets passed to the lambda.</div>
<div><br>
</div>
<div>I have tried to follow all directions outlined in the github
wiki and appreciate any and all feedback.</div>
<div><br>
</div>
<div>Cheers,<br>
Jeremy</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</body>
</html>