<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Hello again Michael!<br>
    I've refetched and it is now located in the 'master-pu' branch.<br>
    <br>
    BR Fredrik Gustafsson<br>
    Erlang OTP Team<br>
    On 12/19/2012 07:05 PM, Michael Loftis wrote:
    <blockquote
cite="mid:CAHDg04te70rtG2HY=HHnDXssZA4+F647iBN061OOATuCo9_uaQ@mail.gmail.com"
      type="cite">
      <div dir="ltr">Entirely my fault, I missed two #define's when I
        moved the patch from the crypto module I forked back at R13 back
        into the R15 source.  I only got R15 to compile today, R15 and
        my javac do not get along (but I don't use any of that anyway).
        <div>
          <br>
        </div>
        <div>I've updated the github repo, same branch.</div>
        <div><br>
        </div>
        <div><br>
        </div>
        <div>
          <div style="font-family:arial,sans-serif;font-size:13px"><a
              moz-do-not-send="true"
href="https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest"
              target="_blank">https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest</a><br>
          </div>
          <div style="font-family:arial,sans-serif;font-size:13px"><a
              moz-do-not-send="true"
href="https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest.patch"
              target="_blank">https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest.patch</a><br>
          </div>
          <div style="font-family:arial,sans-serif;font-size:13px"><br>
          </div>
          <div style="font-family:arial,sans-serif;font-size:13px">git
            fetch git://<a moz-do-not-send="true"
              href="http://github.com/mloftis/otp.git" target="_blank">github.com/mloftis/otp.git</a> crypto-add-ripemd160-digest</div>
        </div>
        <div><br>
        </div>
      </div>
      <div class="gmail_extra"><br>
        <br>
        <div class="gmail_quote">On Wed, Dec 19, 2012 at 1:15 AM,
          Fredrik <span dir="ltr"><<a moz-do-not-send="true"
              href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div text="#000000" bgcolor="#FFFFFF"> Hello Michael,<br>
              It does not build:<br>
              crypto.c: In function ‘ripemd160’:<br>
              crypto.c:621:28: error: ‘RIPEMD160_LEN’ undeclared (first
              use in this function)<br>
              crypto.c:621:28: note: each undeclared identifier is
              reported only once for each function it appears in<br>
              crypto.c: In function ‘ripemd160_init’:<br>
              crypto.c:627:64: error: ‘RIPEMD160_CTX_LEN’ undeclared
              (first use in this function)<br>
              crypto.c: In function ‘ripemd160_update’:<br>
              crypto.c:636:22: error: ‘RIPEMD160_CTX_LEN’ undeclared
              (first use in this function)<br>
              crypto.c: In function ‘ripemd160_final’:<br>
              crypto.c:650:73: error: ‘RIPEMD160_CTX_LEN’ undeclared
              (first use in this function)<br>
              crypto.c:654:47: error: ‘RIPEMD160_LEN’ undeclared (first
              use in this function)<br>
              <br>
              Please take a look at this and give me a notice.
              <div class="im"><br>
                <br>
                BR Fredrik Gustafsson<br>
                Erlang OTP Team<br>
                On 12/18/2012 11:10 PM, Michael Loftis wrote: </div>
              <blockquote type="cite">
                <div>
                  <div class="h5">
                    <div dir="ltr">Apologies, done...
                      <div><br>
                      </div>
                      <div><a moz-do-not-send="true"
href="https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest"
                          target="_blank">https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest</a><br>
                      </div>
                      <div><a moz-do-not-send="true"
href="https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch"
                          target="_blank">https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch</a><br>
                      </div>
                      <div><br>
                      </div>
                      <div> git fetch<span
                          style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"> git://</span><a
                          moz-do-not-send="true"
                          href="http://github.com/mloftis/otp.git"
                          style="font-family:arial,sans-serif;font-size:13px"
                          target="_blank">github.com/mloftis/otp.git</a><span
style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"> crypto-add-ripemd160-digest</span></div>
                      <div><span
                          style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br>
                        </span></div>
                      <div><span
                          style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br>
                        </span></div>
                    </div>
                    <div class="gmail_extra"> <br>
                      <br>
                      <div class="gmail_quote">On Tue, Dec 18, 2012 at
                        1:45 PM, Tuncer Ayaz <span dir="ltr"><<a
                            moz-do-not-send="true"
                            href="mailto:tuncer.ayaz@gmail.com"
                            target="_blank">tuncer.ayaz@gmail.com</a>></span>
                        wrote:<br>
                        <blockquote class="gmail_quote" style="margin:0
                          0 0 .8ex;border-left:1px #ccc
                          solid;padding-left:1ex">
                          <div>On Tue, Dec 18, 2012 at 10:35 PM, Michael
                            Loftis wrote:<br>
                            ><br>
                            > Add ripemd160 digest support to crypto.
                            Includes a couple test<br>
                            > cases.<br>
                            ><br>
                            ><br>
                          </div>
                          <div>> git fetch git://<a
                              moz-do-not-send="true"
                              href="http://github.com/mloftis/otp.git"
                              target="_blank">github.com/mloftis/otp.git</a>
                            crypto-add-ripemd160-digest<br>
                            ><br>
                            > This is based off of master-pu as of a
                            few moments ago, my read of<br>
                            > the requirements tells me that should
                            be the correct spot since I'm<br>
                            > adding a new feature to the crypto
                            module.<br>
                            <br>
                          </div>
                          A patch for 'master-pu' has to be based off
                          'master'.<br>
                          <div>
                            <div><br>
                              > Not fully tested with the current
                              erlang since jinterface has<br>
                              > completely broken my build on all
                              platforms -- even if it is<br>
                              > disabled it still kills my build on
                              most platforms because it's<br>
                              > using sh with scripts that have bash
                              semantics. Might have a chance<br>
                              > to clean up that separate issue today
                              and submit patches.<br>
                            </div>
                          </div>
                        </blockquote>
                      </div>
                      <br>
                      <br clear="all">
                      <div><br>
                      </div>
                      -- <br>
                      <br>
                      "Genius might be described as a supreme capacity
                      for getting its possessors<br>
                      into trouble of all kinds."<br>
                      -- Samuel Butler<br>
                      <br>
                    </div>
                    <br>
                    <fieldset></fieldset>
                    <br>
                  </div>
                </div>
                <div class="im">
                  <pre>_______________________________________________
erlang-patches mailing list
<a moz-do-not-send="true" href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a>
<a moz-do-not-send="true" href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
                </div>
              </blockquote>
              <br>
            </div>
          </blockquote>
        </div>
        <br>
        <br clear="all">
        <div><br>
        </div>
        -- <br>
        <br>
        "Genius might be described as a supreme capacity for getting its
        possessors<br>
        into trouble of all kinds."<br>
        -- Samuel Butler<br>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>