<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello again,<br>
So what you are saying is that it is the patch that is reporting
column numbers and the patch that is removing unused mnemosyne code?<br>
Neither of these patches has been graduated, they are in master-pu,
the same as your patch.<br>
I will discuss with the responsible developers of the applications
concerned here and get back to you.<br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 12/17/2012 11:21 AM, Stavros Aronis wrote:
<blockquote
cite="mid:CABOX0Z8Zk-A6n1V+4y_q8qCB-p-smqwMhpzQt4e95u7UrOY18g@mail.gmail.com"
type="cite">Btw,
<div><br>
</div>
<div>the different error I get on master-pu comes from a very
weird error on mnesia:</div>
<div><br>
</div>
<div>
<div>On mnesia.erl, line 2739 there is a call to missing
function mnesia:get_activity_id/0.</div>
</div>
<div><br>
</div>
<div>This function was removed in commit
6f4c3d127e33d59ac87a3c3b600f7a7280c9674a, part of the patch that
removes unused mnemosyne code.</div>
<div><br>
</div>
<div>Regards,</div>
<div class="gmail_extra">
<br>
<br>
<div class="gmail_quote">On Mon, Dec 17, 2012 at 11:09 AM,
Stavros Aronis <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:aronisstav@gmail.com" target="_blank">aronisstav@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Fredrik,
<div><br>
</div>
<div>Running the tests on my branch (which is rebased on
maint) does not yield any errors.</div>
<div><br>
</div>
<div>Running the tests on master-pu, I get a different
error.</div>
<div><br>
</div>
<div>
By manually running the test I can see that the error that
you report comes from what I would guess is the new
extension that reports column numbers along file lines.</div>
<div><br>
</div>
<div>Has this patch graduated on master? What is the
suggested course of action?</div>
<div><br>
</div>
<div>Regards,</div>
<div><br>
</div>
<div>Stavros</div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Mon, Dec 17, 2012 at 10:22
AM, Fredrik <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello
Stavros!<br>
This fails:<br>
'small_SUITE : empty_list_infimum'<br>
with reason:<br>
<span>dialyzer:format_warning failed on line 295
Reason: function_clause</span><br>
On all platforms..<br>
Please fix this, and I will re-fetch.
<div><br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 12/14/2012 10:11 AM, Stavros Aronis wrote:
</div>
<blockquote type="cite">
<div>
<div>This patch enables Dialyzer to detect
cases where a function has a specification
for a return type containing some list
with elements different than those
Dialyzer's own algorithm can infer e.g. a
function specified to return [atom()] when
actually [[atom()]] is returned.<br>
<div class="gmail_quote">
<div> <br>
</div>
<div>Previously Dialyzer remained silent
under normal operation, seeing that
these two types have the empty list as
a common element, so the spec was not
'completely irrelevant'.</div>
<div><br>
</div>
<div> Using this patch one can find
discrepancies in the specs of
stdlib's sys.erl and erl_scan.erl.
Kostis and I are in contact with the
OTP team for the best way fix those as
well.</div>
<div><br>
</div>
<div> git fetch git://<a
moz-do-not-send="true"
href="http://github.com/aronisstav/otp.git"
target="_blank">github.com/aronisstav/otp.git</a> dialyzer-list-spec</div>
<div><br>
</div>
<div>Regards,</div>
<div><br>
</div>
<div>Stavros</div>
<div><br>
</div>
<div>---</div>
<div><br>
</div>
<div>The new warnings are:</div>
<div><br>
</div>
<div>sys.erl:303: Invalid type
specification for function
sys:handle_debug/4. The success typing
is ([{_,_}],_,_,_) -> [{_,_}]<br>
</div>
<div>
<div> erl_scan.erl:204: Invalid type
specification for function
erl_scan:token_info/2. The success
typing is (_,'category' | 'column' |
'length' | 'line' | 'location' |
'symbol' | 'text' |
maybe_improper_list('category' |
'column' | 'length' | 'line' |
'location' | 'symbol' |
'text','category' | 'column' |
'length' | 'line' | 'location' |
'symbol' | 'text' | [])) ->
'undefined' |
maybe_improper_list({_,_},'undefined'
| [] | {_,_}) | {_,_}</div>
<div>erl_scan.erl:242: Invalid type
specification for function
erl_scan:attributes_info/2. The
success typing is (_,'column' |
'length' | 'line' | 'location' |
'text' |
maybe_improper_list('column' |
'length' | 'line' | 'location' |
'text','column' | 'length' | 'line'
| 'location' | 'text' | [])) ->
'undefined' |
maybe_improper_list({_,_},'undefined'
| [] | {_,_}) | {_,_}</div>
</div>
<div><br>
</div>
</div>
<br>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
erlang-patches mailing list
<a moz-do-not-send="true" href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a>
<a moz-do-not-send="true" href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>