<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
This patch does not pass the test.<br>
We would like you to do the "more correct" fix as that is the better
approach.<br>
<br>
Please run the tests and make sure they all pass and before
submitting the patch.<br>
<br>
<br>
Thank you for the contribution!<br>
<br>
<br>
On 05/05/2012 04:02 AM, Bob Ippolito wrote:
<blockquote
cite="mid:CACwMPm-5gi7p=xtYDxKk+Hd-TVAWSu3sPtkzOqTuc2ArvgNi4g@mail.gmail.com"
type="cite">
<div><font color="#222222" face="arial, sans-serif">Fix 2 second
delay after eval in shell running under ssh_cli</font></div>
<div><font color="#222222" face="arial, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, sans-serif">ssh_cli needs
to reply to the tty_geometry message or else group</font></div>
<div><font color="#222222" face="arial, sans-serif">will wait 2000
msec every time an expression is successfully</font></div>
<div><font color="#222222" face="arial, sans-serif">evaluated in
the shell.</font></div>
<div><font color="#222222" face="arial, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, sans-serif">A "more
correct" fix might refactor io_request and io_requests to</font></div>
<div><font color="#222222" face="arial, sans-serif">take Group as
an argument so that it isn't special-cased in</font></div>
<div><font color="#222222" face="arial, sans-serif">handle_msg.</font></div>
<div><font color="#222222" face="arial, sans-serif"><br>
</font></div>
<span style="">git fetch </span><font color="#222222" face="arial,
sans-serif">git://<a moz-do-not-send="true"
href="http://github.com/etrepum/otp.git">github.com/etrepum/otp.git</a> ssh_cli-tty_geometry</font><br
style="">
<br style="">
<font color="#1155cc" face="arial, sans-serif"><u><a
moz-do-not-send="true"
href="https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry">https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry</a></u></font>
<div>
<font color="#1155cc"><u><font face="arial, sans-serif"><a
moz-do-not-send="true"
href="https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry.patch">https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry.patch</a></font></u></font></div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
/Henrik Nord Erlang/OTP</pre>
</body>
</html>