<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 2011-10-26 12:05, Henrik Nord wrote:
<blockquote cite="mid:4EA7DB54.6040402@erlang.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 10/26/2011 10:14 AM, Wei Cao wrote:
<blockquote
cite="mid:CADS4Raz=Fa4nYKO-6qyXciAtS0eUSaG1sCQYBGYiMz4Uv+nX3Q@mail.gmail.com"
type="cite">Fix a crash in erl_interface.<br>
<br>
erl_interface use linux select() to get notified on socket
events, which works when fd is less than 1024.<br>
<br>
however, when fd is larger than 1024, the fd_set structure on
stack gets corrupted and the process crashes soon, <br>
<br>
this is possible when there are lots of connections kept or the
process keeps creating new connect and closing it.<br>
<br>
<br>
git fetch git://<a moz-do-not-send="true"
href="http://github.com/weicao/otp.git" target="_blank">github.com/weicao/otp.git</a>
erl_interface_replace_select_
<div id=":238"> with_poll<br>
<br>
<br>
<a moz-do-not-send="true"
href="https://github.com/weicao/otp/compare/erl_interface_replace_select_with_poll"
target="_blank">https://github.com/weicao/otp/compare/erl_interface_replace_select_with_poll</a><br>
<br>
<a moz-do-not-send="true"
href="https://github.com/weicao/otp/compare/erl_interface_replace_select_with_poll.patch"
target="_blank">https://github.com/weicao/otp/compare/erl_interface_replace_select_with_poll.patch</a><br
clear="all">
</div>
</blockquote>
</blockquote>
<br>
Though poll would be nice here it isn't supported on all platforms.
For this patch to be accepted a configure test needs to be done to
determine if poll exists and have select as a fallback if doesn't.<br>
<br>
// Björn-Egil<br>
<br>
<blockquote cite="mid:4EA7DB54.6040402@erlang.org" type="cite">
<blockquote
cite="mid:CADS4Raz=Fa4nYKO-6qyXciAtS0eUSaG1sCQYBGYiMz4Uv+nX3Q@mail.gmail.com"
type="cite">
<div id=":238"> <font color="#888888"> </font></div>
<br clear="all">
<br>
-- <br>
<br>
Best,<br>
<br>
Wei Cao<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
Hi<br>
1. The commit msg is not conforming to the guidelines on how to
write a proper commit msg.<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://github.com/erlang/otp/wiki/Writing-good-commit-messages">https://github.com/erlang/otp/wiki/Writing-good-commit-messages</a><br>
<br>
2. could you add tests for this?<br>
<br>
<br>
Thank you for the contribution!<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
/Henrik Nord Erlang/OTP</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</body>
</html>