<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject: </th>
<td>Re: [erlang-patches] jinterface: improve error message for
too long OtpErlangAtom</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Tue, 15 Nov 2011 11:19:06 +0100</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>Henrik Nord <a class="moz-txt-link-rfc2396E" href="mailto:henrik@erlang.org"><henrik@erlang.org></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td>Vlad Dumitrescu <a class="moz-txt-link-rfc2396E" href="mailto:vladdu55@gmail.com"><vladdu55@gmail.com></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 11/11/2011 04:02 PM, Vlad Dumitrescu wrote:
<blockquote
cite="mid:CAA-EFXukMXpWpRBZQ6+U26i=ieX7OHgR5O-OEB_5XeXpFB91Uw@mail.gmail.com"
type="cite">
<pre wrap="">Hi!
When trying to create an OtpErlangAtom longer than 255 characters, the
error doesn't say what was the actual value. It would have saved me a
lot of debugging time if it had been included in the error message.
This patch addresses that. Please let me know if you want a test case
for this, personally I think it's trivial enough to not need one.
git fetch git://github.com/vladdu/otp.git jinterface_atom_message
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://github.com/vladdu/otp/compare/jinterface_atom_message">https://github.com/vladdu/otp/compare/jinterface_atom_message</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://github.com/vladdu/otp/compare/jinterface_atom_message.patch">https://github.com/vladdu/otp/compare/jinterface_atom_message.patch</a></pre>
</blockquote>
<br>
<blockquote
cite="mid:CAA-EFXukMXpWpRBZQ6+U26i=ieX7OHgR5O-OEB_5XeXpFB91Uw@mail.gmail.com"
type="cite">
<pre wrap="">
(BTW there is still no maint branch as the instructions say, so it's
based on dev)
</pre>
</blockquote>
"<br>
<pre wrap="">New Branching strategy short version:
The branch 'master' will be the upcoming major release (e.g. R15).
Branch from this to submit patches for the next major release.
(New features and major changes)
New branch 'maint' will be introduced AFTER R15, and will be the next maintenance release (e.g. R15B01)
Branch from this to submit patches for the next maintenance release.
(Bug fixes and minor changes)
The 'pu' branch will be based on 'master' and we will later add a 'maint-pu' for the 'maint' branch.
"
</pre>
Also do not use 'dev' it will never be used again, and will be
removed from github soon<strong>™, also out of date.<br>
</strong>
<blockquote
cite="mid:CAA-EFXukMXpWpRBZQ6+U26i=ieX7OHgR5O-OEB_5XeXpFB91Uw@mail.gmail.com"
type="cite">
<pre wrap="">best regards,
Vlad
_______________________________________________
erlang-patches mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
I will include this in 'pu', I rebased the branch upon master, and
did a small change in the commit msg.<br>
<br>
Thank you for the contribution!<br>
<br>
<pre class="moz-signature" cols="72">--
/Henrik Nord Erlang/OTP</pre>
</body>
</html>