<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 11/01/2011 04:13 PM, Ahmed Omar wrote:
<blockquote
cite="mid:CALxv_xZFGkAmhca9GYG_9GVPtR3xnpsSub25=rXnFpgRzuP8=g@mail.gmail.com"
type="cite">
<p>git fetch git://<a moz-do-not-send="true"
href="http://github.com/spawnthink/otp.git" target="_blank">github.com/spawnthink/otp.git</a> fix_change_time_inval_dates</p>
<p><a moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_change_time_inval_dates">https://github.com/spawnthink/otp/compare/fix_change_time_inval_dates</a></p>
<p><a moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_change_time_inval_dates.patch">https://github.com/spawnthink/otp/compare/fix_change_time_inval_dates.patch</a></p>
<br>
<div class="gmail_quote">On Tue, Nov 1, 2011 at 3:11 PM, Henrik
Nord <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:henrik@erlang.org">henrik@erlang.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div bgcolor="#FFFFFF" text="#000000">
<div class="im"> <br>
Issue : <a moz-do-not-send="true"
href="http://comments.gmane.org/gmane.comp.lang.erlang.bugs/2657"
target="_blank">http://comments.gmane.org/gmane.comp.lang.erlang.bugs/2657</a>
<div><br>
</div>
<div>
<p>git fetch git://<a moz-do-not-send="true"
href="http://github.com/spawnthink/otp.git"
target="_blank">github.com/spawnthink/otp.git</a>
fix_atime_mtime</p>
<p><a moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_atime_mtime.patch"
target="_blank">https://github.com/spawnthink/otp/compare/fix_atime_mtime</a></p>
<p><br>
</p>
<p><a moz-do-not-send="true"
href="https://github.com/spawnthink/otp/compare/fix_atime_mtime.patch"
target="_blank">https://github.com/spawnthink/otp/compare/fix_atime_mtime.patch</a></p>
<div><br>
</div>
-- </div>
<br>
</div>
<div class="im"> On 10/27/2011 09:50 PM, Ahmed Omar wrote:
<blockquote type="cite">Added another fix there
<div><a moz-do-not-send="true"
href="https://github.com/spawnthink/otp/commit/cbe886c1fdb9db4a639aa911f9c691b4d86ec48b"
target="_blank">https://github.com/spawnthink/otp/commit/cbe886c1fdb9db4a639aa911f9c691b4d86ec48b</a></div>
<div><br>
</div>
<div>for issue reported by <span style="color:rgb(119,
119, 119);font-family:arial,
sans-serif;font-size:13px;background-color:rgb(255,
255, 255)"><a moz-do-not-send="true"
href="mailto:systemio@mail.ru" target="_blank">systemio@mail.ru</a></span></div>
<div><br>
</div>
<div>Please refetch</div>
<div><br>
</div>
</blockquote>
<blockquote type="cite">
<div>Note : please let me know if you need me to
separate them in different branches.<br>
</div>
</blockquote>
<br>
<br>
<br>
</div>
Hi<br>
Regarding the first patch, (atime, mtime) we will not use it
due to our aim to rewrite those parts of the file driver for
R15<br>
<br>
The second part, when <a moz-do-not-send="true">file:change_time/2,3</a>
are called with invalid dates, we would like.<br>
<br>
Could you separate that in its own branch, with a properly
formatted commit msg for me?<br>
<a moz-do-not-send="true"
href="https://github.com/erlang/otp/wiki/Writing-good-commit-messages"
target="_blank">https://github.com/erlang/otp/wiki/Writing-good-commit-messages</a><br>
(line length , imperative mode fix, instead of fixes etc..)<br>
<font color="#888888"> <br>
<br>
<br>
<pre cols="72">--
/Henrik Nord Erlang/OTP</pre>
</font></div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Best Regards,<br>
- Ahmed Omar
<div><a moz-do-not-send="true"
href="http://nl.linkedin.com/in/adiaa" target="_blank">http://nl.linkedin.com/in/adiaa</a></div>
<div>Follow me on twitter</div>
<div><a moz-do-not-send="true"
href="http://twitter.com/#%21/spawn_think" target="_blank">@spawn_think</a></div>
<br>
</blockquote>
Thank you!<br>
I have included your branch in 'pu'<br>
<br>
<pre class="moz-signature" cols="72">--
/Henrik Nord Erlang/OTP</pre>
</body>
</html>