<br><br><div class="gmail_quote">2011/9/14 Christopher Faulet <span dir="ltr"><<a href="mailto:christopher.faulet@capflam.org">christopher.faulet@capflam.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Le 14/09/2011 11:51, Siri Hansen a écrit :<br>
<div class="im">> I have discussed the simple_one_for_one_shutdown problem with my<br>
> colleagues, and finally we came to the same conclusion as you did :) The<br>
> current behavior is definitely not acceptable so we decided to take in<br>
> you patch. If you don't mind I would however like you to do some minor<br>
> adjustments first:<br>
><br>
> 1) I think it would be good to document the differences in how shutdown<br>
> is handled for simple_one_for_one supervisors compared to other<br>
> supervisors. I.e. that there is no defined shutdown order, and that the<br>
> workers will terminate "in parallel".<br>
><br>
> 2) If the shutdown strategy for the dynamic children is a timer, and the<br>
> timer expires - then it looks like there will be one error report<br>
> printed per worker that is not yet terminated (please correct me if I'm<br>
> wrong). I believe that this could be quite heavy if there are many<br>
> workers left. I would suggest to print only one error report in this<br>
> situation - either listing all pids or just say how many processes we<br>
> are talking about.<br>
><br>
><br>
> Also, as Henrik writes, your supervisor_shutdown_infinity patch is<br>
> already included in pu. Before finally including it in our development<br>
> branch, I would also like you to add some more information to the<br>
> documentation (a warning?) - about using this feature with care, and if<br>
> you need to use it then implement the worker in a safe way so the<br>
> cleanup procedure can not hang... since this can actually cause the<br>
> termination of the complete supervisor tree to hang.<br>
><br>
<br>
</div>Siri,<br>
<br>
Thanks for your feedback. You can re-fetch the branches:<br>
<br>
git fetch git://<a href="http://github.com/capflam/otp.git" target="_blank">github.com/capflam/otp.git</a> simple_one_for_one_shutdown<br>
<div class="im">git fetch git://<a href="http://github.com/capflam/otp.git" target="_blank">github.com/capflam/otp.git</a> supervisor_shutdown_infinity<br>
<br>
</div>Let me know if there is any problem with my updates (Especially with the<br>
documentation).<br>
<div><div></div><div class="h5"><br>
--<br>
Christopher Faulet<br>
<a href="http://www.yakaz.com" target="_blank">http://www.yakaz.com</a><br>
<br>
</div></div></blockquote></div><br><div>Thanks Christopher - it looks good! :)</div><div>/siri</div>