I haven't heard back from Henrik on this, so am resending to the list.<div><br></div><div>tj<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Travis Jensen</b> <span dir="ltr"><<a href="mailto:travis.jensen@gmail.com">travis.jensen@gmail.com</a>></span><br>
Date: Fri, May 6, 2011 at 12:58 PM<br>Subject: Re: [erlang-patches] True streaming of AES CTR<br>To: Henrik Nord <<a href="mailto:henrik@erlang.org">henrik@erlang.org</a>><br><br><br>I'm not sure what's happening here. The code is there, I promise. :) I just did the following, and everything checked out correctly:<div>
<br></div><div><font face="'courier new', monospace">git clone <a href="https://github.com/erlang/otp.git" target="_blank">https://github.com/erlang/otp.git</a> .</font></div>
<div><font face="'courier new', monospace">git fetch <a href="https://github.com/SoftwareMaven/otp.git" target="_blank">https://github.com/SoftwareMaven/otp.git</a> streaming_crypto_functions</font></div><div><font face="'courier new', monospace">git checkout pu</font></div>
<div><font face="'courier new', monospace">git merge 487ed88cdff77e55273b4c62a60c0203f90bd7b0</font><br><br></div><div>That said, I made a new branch and re-committed the files to the new branch. It should be happily found at:</div>
<div><br></div><div><span style="font-family:'courier new', monospace">git fetch </span><font face="'courier new', monospace"><a href="https://github.com/SoftwareMaven/otp.git" target="_blank">https://github.com/SoftwareMaven/otp.git</a> streaming_crypto_funcs</font></div>
<div><br></div><div>The commit point on that one is 299a2ee97fa5ee82eaeeb150cc88c95110258ba9.</div><div><br></div><div>I realize you are into the weekend now, but I'll make sure I'm on top of anything I can be over said weekend. I'll also plan on staying up late on my Sunday (your Monday morning) to cover anything at that point. </div>
<div><br></div><div>Sorry for being such a...git. ;)</div><div><br></div><font color="#888888"><div>tj</div></font><div><div></div><div class="h5"><div><br></div><div><div class="gmail_quote">On Fri, May 6, 2011 at 2:29 AM, Henrik Nord <span dir="ltr"><<a href="mailto:henrik@erlang.org" target="_blank">henrik@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#ffffff" text="#000000"><div>
On 05/06/2011 01:57 AM, Travis Jensen wrote:
</div><div><div></div><div><blockquote type="cite">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
<div bgcolor="#ffffff" text="#000000"> <br>
These tests have started to fail after this branch was
included in 'pu'<br>
<br>
crypto_SUITE:hmac_update <br>
crypto_SUITE:rc4_stream_test <br>
crypto_SUITE:rc4_test <br>
crypto_SUITE:smp <br>
<br>
The deadline for R14B03 approaches so I will need fixes
early next week if you want this to be included.<br>
Thanks!<br>
<br>
Ps<br>
Let me know if you require more info<br>
<font color="#888888"> <br>
<pre cols="72">--
/Henrik Nord Erlang/OTP</pre>
</font></div>
</blockquote>
</div>
<div><br>
</div>
Hi, Henrik,
<div><br>
</div>
<div>I've made an update to my branch that addresses the first 3
(problem as the all() list not referencing the correct
functions). </div>
<div><br>
</div>
<div>
<font face="'courier new', monospace"><span style="border-collapse:collapse;font-size:13px">git fetch git://</span><span style="border-collapse:collapse;font-size:13px"><a href="http://github.com/SoftwareMaven/otp.git" style="color:rgb(51, 51, 204)" target="_blank">github.com/SoftwareMaven/otp.git</a></span><span style="border-collapse:collapse;font-size:13px"> </span><span style="border-collapse:collapse;font-size:13px"> streaming_crypto_functions</span></font></div>
<div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px"><br>
</span></div>
<div>The rc4_ failures were a result of emacs substituting special
characters behind my back; I did not modify any code there (I
tell you so you know what I'm changing and what you have to
worry about those changes impacting), so it is reverted to what
existed previous to my commit. </div>
<div><br>
</div>
<div>The smp test was failing because it references the rc4_
tests. I've added my new tests to the smp test as well so they
will be tested in multiple processes.</div>
<div><br>
</div>
<div>I'm having a heck of a time getting unit tests running. I am
running them manually using:</div>
<div><br>
</div>
<div><font face="'courier new',
monospace">lists:map(fun(T) -> </font></div>
<div><font face="'courier new',
monospace"> io:format("~p~n", [T]), </font></div>
<div><font face="'courier new',
monospace"> apply(crypto_SUITE, T, [[]]) </font></div>
<div><font face="'courier new',
monospace"> end,</font></div>
<div><font face="'courier new',
monospace"> crypto_SUITE:all()).</font></div>
<div><br>
</div>
<div>so there is a chance I may be missing something, however, all
of the these did run and there were no errors.</div>
<div><br>
</div>
<div>I will continue working on getting the unit tests running
officially. If there are other issues, this is my current #1
priority at work. :)</div>
<div><br>
</div>
<div>Thanks.</div>
<div><br>
</div>
<div>tj</div>
<div>-- <br>
<b><span style="font-size:large">Travis Jensen</span></b>
<div><span style="font-size:large"><b><br>
</b></span>Read the Software Maven @ <a href="http://softwaremaven.innerbrane.com/" target="_blank">http://softwaremaven.innerbrane.com/</a><br>
Read my LinkedIn profile @ <a href="http://www.linkedin.com/in/travisjensen" target="_blank">http://www.linkedin.com/in/travisjensen</a><br>
Read my Twitter mumblings @ <a href="http://twitter.com/SoftwareMaven" target="_blank">http://twitter.com/SoftwareMaven</a><br>
Send me email @ <a href="mailto:travis.jensen@gmail.com" target="_blank">travis.jensen@gmail.com</a>
<div><br>
</div>
<div><i>*What kind of guy calls himself the Software Maven???*</i></div>
</div>
<br>
</div>
</blockquote></div></div>
Oo<br>
I rechecked you branch, and it looks like you have made something
strange with it.<br>
<br>
* Add true streaming AES (CTR) encryption and streaming HMAC
operations<br>
Is now gone?<br>
<br>
and there are a strange "Merge git://<a href="http://github.com/erlang/otp" target="_blank">github.com/erlang/otp</a> into
streaming_crypto_functions" there instread, followed by the 2
commits to scrypto_SUIT.erl<br>
Resolve unittest failures for streaming encryption<br>
Add streaming AES CTR and HMAC functions to smp test<br><font color="#888888">
<br>
<br>
<pre cols="72">--
/Henrik Nord Erlang/OTP</pre>
</font></div>
</blockquote></div><br><br clear="all"><br>-- <br><b><span style="font-size:large">Travis Jensen</span></b><div><b></b><span style="font-size:large"><b><br></b></span>Read the Software Maven @ <a href="http://softwaremaven.innerbrane.com/" target="_blank">http://softwaremaven.innerbrane.com/</a><br>
Read my LinkedIn profile @ <a href="http://www.linkedin.com/in/travisjensen" target="_blank">http://www.linkedin.com/in/travisjensen</a><br>Read my Twitter mumblings @ <a href="http://twitter.com/SoftwareMaven" target="_blank">http://twitter.com/SoftwareMaven</a><br>
Send me email @ <a href="mailto:travis.jensen@gmail.com" target="_blank">travis.jensen@gmail.com</a><div><br></div><div><i>*What kind of guy calls himself the Software Maven???*</i></div></div><br>
</div>
</div></div></div><br><br clear="all"><br>-- <br><b><span style="font-size:large">Travis Jensen</span></b><div><b></b><span style="font-size:large"><b><br></b></span>Read the Software Maven @ <a href="http://softwaremaven.innerbrane.com/" target="_blank">http://softwaremaven.innerbrane.com/</a><br>
Read my LinkedIn profile @ <a href="http://www.linkedin.com/in/travisjensen" target="_blank">http://www.linkedin.com/in/travisjensen</a><br>Read my Twitter mumblings @ <a href="http://twitter.com/SoftwareMaven" target="_blank">http://twitter.com/SoftwareMaven</a><br>
Send me email @ <a href="mailto:travis.jensen@gmail.com" target="_blank">travis.jensen@gmail.com</a><div><br></div><div><i>*What kind of guy calls himself the Software Maven???*</i></div></div><br>
</div>