[erlang-patches] allow use of proplists in supervisor start specs

DeadZen deadzen@REDACTED
Tue Sep 23 16:27:21 CEST 2014


Once you find the reason for something, it always makes more sense..
The fact that you're reconsidering changing intensity/period now is
prudent and respectable.

On Wed, Sep 17, 2014 at 9:30 AM, Siri Hansen <erlangsiri@REDACTED> wrote:
> Thanks again for the input :)
>
> So, I'll definitely change 'name' back to 'id'. However, regarding
> 'intensity' and 'period' I think I found the reason why these names were
> used in the first place. These are the names used internally in the
> supervisor module (for variables names and fields in the state record), but
> more importantly, they are used in error messages - 'invalid_intensity',
> 'invalid_period' (and 'reached_max_restart_intensity'... :-P ). Considering
> the backwards compatibility we do not want to change these error messages,
> so now I'm back to thinking that maybe 'intensity' and 'period' are not so
> bad after all... ?? Or rather, there are pros and cons for everything, but
> maybe this would give the most consistent feel to the complete interface.
>
> /siri
>
>
>
> 2014-09-03 18:33 GMT+02:00 Ulf Wiger <ulf@REDACTED>:
>>
>>
>> On 03 Sep 2014, at 13:50, Siri Hansen <erlangsiri@REDACTED> wrote:
>>
>> Over the summer we have had some internal reviews of the documentation and
>> I got some feedback on the naming. Specifically, questions are raised about
>> the keys 'name', 'intensity' and 'period'. With the old tuple format, these
>> three values are named Id, MaxR and MaxT respectively, and the questions are
>> if they should be changed at all and if so, are the suggested names "the
>> best"…
>>
>>
>> Ah, how did I miss this?
>>
>> Time for me to mention, again, the supervisor extension I made back in
>> 2001:
>>
>> http://erlang.2086793.n4.nabble.com/Supervisor-shutdown-td4663655.html
>>
>> Just as some added input. ;-)
>>
>> BR,
>> Ulf W
>>
>> Ulf Wiger, Co-founder & Developer Advocate, Feuerlabs Inc.
>> http://feuerlabs.com
>>
>>
>>
>



More information about the erlang-patches mailing list