[erlang-patches] Fix DTrace build on Illumos
Wed Feb 5 10:03:00 CET 2014
Ok, thanks, good to know. I'll rewrite it so that the error message gets
put in the config.log instead of being printed to stdout.
On 04/02/14 22:10, Ryan Zezeski wrote:
> Hi Lukas,
> If I recall correctly, I did that so that the exact failure reason
> would be more obvious when dtrace fails build. When I first ran into
> this problem months ago it was hard for me to determine what the issue
> was and my thinking is that this output would help. Perhaps it is not
> useful? I will not object if you feel this particular change needs to
> be reverted but I also didn't make the change by accident.
> On Tue, Feb 4, 2014 at 12:24 PM, Lukas Larsson <
> <mailto:>> wrote:
> Hello Ryan,
> I just noticed that you removed the "2> /dev/null" for the
> 2STEP_TEST in erts/configure.in <http://configure.in>. Was there a
> reason for doing that? As it is now when the test fails on osx in
> prints the output of the dtrace command to the shell which is not
> really what you want.
> On 15/01/14 23:32, Ryan Zezeski wrote:
>> Any news? Would be nice if R17 worked with DTrace on latest
>> Illumos kernel.
>> On Tue, Dec 10, 2013 at 8:26 AM, Henrik Nord <
>> <mailto:>> wrote:
>> Thank you for your contribution !
>> patch has been assigned to be reviewed
>> On 2013-12-07 22:00, Ryan Zezeski wrote:
>>> This patch fixes the configure and Makefile scripts to work
>>> with newer DTrace. This applies to all Illumos derivatives
>>> including OpenIndiana, SmartOS and OmnioOS. I've copied the
>>> commit message here verbatim.
>>> --- SNIP ---
>>> Fix DTrace build on Illumos
>>> DTrace was recently patched in Illumos to fail to create
>>> an object
>>> file if no probes are found.
>>> * https://www.illumos.org/issues/4248
>>> This patch fixes two issues:
>>> * Modify the configure script to pass an object file to
>>> `dtrace -G`
>>> that actually invokes a probe.
>>> * Remove creation of `dtrace_user.o` from the dyntrace
>>> Makefile. In a
>>> previous commit  Scott Fritchie relocated all the
>>> user probes
>>> into the VM proper due to difficulties with DTrace
>>> probes in shared
>>> libraries. The `dtrace_user.d` file is now empty and
>>> generates a
>>> header file with nothing in it. There is no longer any
>>> reason to
>>> generate `dtrace_user.o` because all the probes are in
>>> the VM. Thus
>>> all the steps for building `dtrace_user.o` have been
>>> --- END SNIP ---
>>> erlang-patches mailing list
>> /Henrik Nord Erlang/OTP
>> erlang-patches mailing list
> erlang-patches mailing list
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the erlang-patches