[erlang-patches] R17.0-rc1 patch for gzio.c compile breakage.

[Daniel Goertzen]

Thank you for the merge.  And you piqued my curiosity as to the why.

My gentoo zconf.h defines the macro as _Z_OF instead of OF.  Digging
deeper, they made the change on the premise that OF is a stupid, polluting
name for an internal macro.  There was disagreement as to the value of the
change (https://bugs.gentoo.org/show_bug.cgi?id=383179)


Dan.



On Tue, Feb 4, 2014 at 8:27 AM, Björn Gustavsson <bjorn@REDACTED> wrote:

> On Mon, Feb 3, 2014 at 6:35 PM, Daniel Goertzen
> <daniel.goertzen@REDACTED> wrote:
> > A dependency on zlib.h was recently removed (commit 8a147a7365).  This
> also
> > removes the definition of the macro "OF" which is required by gzio.c.
>  Now
> > "OF" is evidently defined by other headers on some systems, but on at
> least
> > Gentoo Linux this is not the case.
>
> The OF() macro is defined in zconf.h, which is included by zlib.h, so
> I don't understand why the build should break on Gentoo Linux.
>
> But since the use of OF() is completely unnecessary and is an
> unnecessary dependency I have written a commit message for your
> patch and included it in our daily builds.
>
> git fetch git@REDACTED:bjorng/otp.git bjorn/erts/zlib-1.2.8/OTP-11669
>
> /Bjorn
>
> --
> Björn Gustavsson, Erlang/OTP, Ericsson AB
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140204/abdfc5c0/attachment.htm>