[erlang-patches] Fix crash in mnesia_controller due to a function_clause exception from is_tab_blocked/1

[Dan Gudmundsson]

Hi

I believe the bug is that block_table is called twice, I don't think that
should happen.
It was some time ago I wrote that part, so can you try to investigate why
that happens?

I do not want to take this patch as it is, without knowing why it happens,
since it may mask
other more serious faults.

/Dan


On Thu, May 2, 2013 at 10:23 AM, Ahmed Omar <spawn.think@REDACTED> wrote:

> Thanks Fredrik for your comments, to avoid confusing commits,
> Please fetch from
>
> git fetch git://github.com/spawnthink/otp.git
> fix_mnesia_block_table_exception
>
> https://github.com/spawnthink/otp/compare/fix_mnesia_block_table_exception
>
> https://github.com/spawnthink/otp/compare/fix_mnesia_block_table_exception.patch
>
>
> On Thu, May 2, 2013 at 10:05 AM, Ahmed Omar <spawn.think@REDACTED> wrote:
>
>> Hello Fredrik,
>> Could you please refetch, I removed an extra call to val(Var)
>> https://github.com/spawnthink/otp/compare/fix_mnesia_block_table
>>
>>
>> On Thu, May 2, 2013 at 9:12 AM, Fredrik <fredrik@REDACTED> wrote:
>>
>>>  On 05/01/2013 03:49 PM, Ahmed Omar wrote:
>>>
>>> git fetch git://github.com/spawnthink/otp.git fix_mnesia_block_table
>>>
>>>  Fix crash in mnesia_controller due to a function_clause exception from
>>> is_tab_blocked/1
>>>
>>>  If mnesia_controller:block_table/1 is called twice for same table,
>>> the new stored value of {Tab, where_to_commit} will be {blocked,
>>> {blocked,List}}.
>>> This will result in an exception when calling is_tab_blocked/1.
>>> mnesia_conttoller:block_table/1 should check if the table is already
>>> blocked.
>>>
>>>  https://github.com/spawnthink/otp/compare/fix_mnesia_block_table.patch
>>>  https://github.com/spawnthink/otp/compare/fix_mnesia_block_table
>>>
>>>  Best Regards,
>>> Ahmed Omar
>>>
>>>
>>> _______________________________________________
>>> erlang-patches mailing listerlang-patches@REDACTED://erlang.org/mailman/listinfo/erlang-patches
>>>
>>>  Hello Ahmed,
>>> I've fetched your patch and it is currently in the 'pu' branch.
>>>
>>> --
>>>
>>> BR Fredrik Gustafsson
>>> Erlang OTP Team
>>>
>>>
>>
>
> _______________________________________________
> erlang-patches mailing list
> erlang-patches@REDACTED
> http://erlang.org/mailman/listinfo/erlang-patches
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130520/8a5d9600/attachment.htm>