[erlang-patches] Relax reltools requirements on excluded applications

[Fredrik]

On 03/19/2013 12:48 PM, Håkan Mattsson wrote:
> On Tue, Mar 19, 2013 at 11:41 AM, Fredrik<fredrik@REDACTED>  wrote:
>> On 03/19/2013 09:38 AM, Håkan Mattsson wrote:
>>> When generating cross compiled systems it is rather inconvenient that
>>> reltool requires that even excluded applications are part of the
>>> configuration. The symptom of this is an error claiming that the
>>> application directory is missing.
>>>
>>> With this patch, a missing a application directory is now classified
>>> as warning if the application is explicitly excluded.
>>>
>>>     git fetch git://github.com/hawk/otp.git hawk/reltool_relaxed_exclude
>>>
>>> or viewed here
>>>
>>>     https://github.com/hawk/otp/compare/hawk/reltool_relaxed_exclude
>>>     https://github.com/hawk/otp/compare/hawk/reltool_relaxed_exclude.patch
>>>
>>> /Håkan
>>> _______________________________________________
>>> erlang-patches mailing list
>>> erlang-patches@REDACTED
>>> http://erlang.org/mailman/listinfo/erlang-patches
>> Hello,
>> Your patch seems not to build,
>>
>> reltool_server_SUITE.erl:1352:33: variable 'Config' is unbound
> Sorry. I did a last minute change in the test program.
> Please, refetch.
>
> /Håkan
Hello again,
Your patch seems to fail a testcase:
reltool_server_SUITE, exclude_non_existing_app
with reason:

reltool_server_SUITE.erl(1371): SPEC: {error,
                                        "Illegal library \"*DIRECTORY*": no such file or directory"}

reltool_server_SUITE.erl(1372):
Not matching actual result was:
	{error,"Illegal library \"*DIRECTORY*": no such file or directory"}
Expected:
	{ok,["foobar: Missing application directory."]}



-- 

BR Fredrik Gustafsson
Erlang OTP Team

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130322/ad67d2a4/attachment.htm>