[erlang-patches] Add 'global' driver option to erl_ddll:try_load/3

[Lukas Larsson]

Hello,

It is still failing to build on windows:

sys/win32/erl_win32_sys_ddll.c(74) : warning C4047: 'function' : 'int' differs in levels of indirection from 'void **'
sys/win32/erl_win32_sys_ddll.c(74) : warning C4024: 'erts_sys_ddll_open_noext' : different types for formal and actual parameter 2
sys/win32/erl_win32_sys_ddll.c(74) : warning C4047: 'function' : 'void **' differs in levels of indirection from 'ErtsSysDdllError *'
sys/win32/erl_win32_sys_ddll.c(74) : warning C4022: 'erts_sys_ddll_open_noext' : pointer mismatch for actual parameter 3
sys/win32/erl_win32_sys_ddll.c(74) : error C2198: 'erts_sys_ddll_open_noext' : too few arguments for call
sys/win32/erl_win32_sys_ddll.c(77) : warning C4028: formal parameter 2 different from declaration
sys/win32/erl_win32_sys_ddll.c(77) : warning C4028: formal parameter 3 different from declaration
sys/win32/erl_win32_sys_ddll.c(77) : warning C4029: declared formal parameter list different from definition
make[3]: *** [obj/win32/opt/smp/erl_win32_sys_ddll.o] Error 2

Lukas


On 20/03/13 18:12, Fredrik wrote:
> On 03/20/2013 06:09 PM, Olivier Girondel wrote:
>> On Wed, Mar 20, 2013 at 6:01 PM, Fredrik<fredrik@REDACTED>  wrote:
>>> Does not seem to build on windows:
>>>
>>> beam/erl_bif_ddll.c(1534) : error C2065: 'RTLD_GLOBAL' : undeclared
>>> identifier
>> I just pushed this:
>>
>> commit bdd0017f087a42f328f77debfb658ab0a0b2bc00
>> Author: Olivier Girondel<olivier@REDACTED>
>> Date:   Wed Mar 20 18:06:13 2013 +0100
>>
>>      Add missing RTLD_GLOBAL definition
>>
>> diff --git a/erts/emulator/beam/erl_bif_ddll.c
>> b/erts/emulator/beam/erl_bif_ddll.c
>> index 91a083c..af8d3be 100644
>> --- a/erts/emulator/beam/erl_bif_ddll.c
>> +++ b/erts/emulator/beam/erl_bif_ddll.c
>> @@ -53,6 +53,9 @@
>>   #define DDLL_SMP 0
>>   #endif
>>
>> +#ifndef RTLD_GLOBAL
>> +#define RTLD_GLOBAL    0x00100
>> +#endif
>>
>> Can you please re-fetch ?
>>
>> Thanks,
>>
> Re-fetched. Let's see how the building and testing goes.
> Thanks,
>