[erlang-patches] Implement add_report_sup_handler which calls gen_event:add_sup_handler

Fredrik <>
Tue Mar 12 15:09:49 CET 2013


On 03/01/2013 08:15 PM, Pedram Nimreezi wrote:
> Hi,
>
> This patch adds add_report_sup_handler to the error_logger module
>
> To eliminate the need to go around the error_logger api, this patch
> allows for a report_handler to be added via add_sup_handler.
>
> https://github.com/DeadZen/otp/compare/error-logger-sup_handler.patch
> https://github.com/DeadZen/otp/compare/error-logger-sup_handler
>
> git fetch git://github.com/DeadZen/otp.git error-logger-sup_handler
>
Hello again,
I've got some feedback on your patch.
*The patch needs tests and documentation
*The spec for add_report_sup_handler/1 is not sufficient, should it be 
"any()" really?
*Your commit message is to short and needs further explanation.

-- 

BR Fredrik Gustafsson
Erlang OTP Team



More information about the erlang-patches mailing list