[erlang-patches] Fix Flymake dependency in erlang-pkg.el

Magnus Henoch <>
Mon Mar 4 12:04:40 CET 2013


Steve Purcell <> writes:

> Hi Magnus,
>
>> I just tried installing the Emacs Erlang mode using the package
>> definition in erlang-pkg.el, and found that the dependency declaration
>> on "flymake-mode" is incorrect - it should be "flymake" instead.  I also
>> decreased the version requirement, as erlang-flymake.el works well with
>> flymake version 0.3 (the one that comes with Emacs).
>
> I believe this fix is insufficient for Emacs 23. In that version, there
> is no bundled `package.el`, and the one which is downloadable does not
> recognise Emacs built-in libraries as packages. ie. on Emacs 23, the
> "flymake" dependency would be unsatisfied.
>
> IMO a better solution would be to omit the dependency altogether, since
> flymake has been standard since (at least) Emacs 23.
>
> I'm a maintainer of MELPA (http://melpa.milkbox.net/), which is an Emacs
> package repository which automatically builds elisp packages from
> upstream source control repositories, so I'm happy that you've addressed
> this issue, because the Erlang package has indeed become uninstallable
> on all Emacs versions due to the "flymake-mode" dependency you fixed.
>
> Would you be able to submit a patch replacing the '(flymake-mode "0.3")
> with a nil, or should I?

Nice catch.  Here is the new version of the patch (on top of the maint
branch):

git fetch git://github.com/legoscia/otp.git fix-emacs-pkg-flymake-dep

https://github.com/legoscia/otp/compare/legoscia:fix-emacs-pkg-flymake-dep
https://github.com/legoscia/otp/compare/legoscia:fix-emacs-pkg-flymake-dep.patch

Regards,
Magnus


More information about the erlang-patches mailing list