[erlang-patches] erl_tidy option to print to stdout

Aaron France <>
Mon Jul 15 13:41:09 CEST 2013


Hi,

Besides from cultivating an entire test suite for the erl_tidy module,
which is outside of the scope for the patch, if I were to provide a test
for the addition, I would essentially be testing a simple print function.
Would I not?

Some pointers on what to test would be a great help, otherwise I'm a bit a
loss as to what to test.

Regards,
Aaron


On Thu, Jul 11, 2013 at 6:54 PM, Andrew Thompson <> wrote:

> On Thu, Jul 11, 2013 at 04:48:12PM +0200, Björn-Egil Dahlberg wrote:
> > It is great that the new option is documented!
> >
> > Especially since syntax_tools is lacking tests, I think it's crucial
> > that tests are added.
> >
> > It is our policy to require tests for all new features unless the
> > feature is already covered under some other test.
>
> Not that I don't applaud this policy, but it can be *extremely*
> difficult to add new tests to a untested/minimally tested codebase.
>
> I know when I've made contributions in the past I've tried to update the
> test suites where applicable, but when there's no tests I've sort of
> thrown up my hands and just submitted the patch.
>
> I don't know the best solution to this, but pushing all the work on the
> contributor seems a little unfair. Maybe the OTP team can help out with
> testing in such cases.
>
> Andrew
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130715/295529cf/attachment.html>


More information about the erlang-patches mailing list