[erlang-patches] erl_tidy option to print to stdout

Björn-Egil Dahlberg <>
Thu Jul 11 16:48:12 CEST 2013


On 2013-07-11 16:11, Richard Carlsson wrote:
> On 2013-07-11 14:26 , Fredrik wrote:
>> On 06/02/2013 09:52 PM, Aaron France wrote:
>>> Hi all,
>>>
>>> I've read the contribution rules and received some cursory guidance
>>> from nox in IRC so I hope I don't awaken any wrath from the format.
>>>
>>> I've added an option to erl_tidy to simply print to stdout. These may
>>> seem a trivial thing to want to have in but my use-case is wanting to
>>> build intermediary steps around erl_tidy and not simply replace the
>>> underlying file.
>>>
>>> Personally, I want to have this (and I am working on it now that I
>>> have patched it in) available to erlang-mode in emacs. So that I can
>>> have a save hook for formatting the code properly. Dealing with files
>>> is less than stellar but dealing with the unixy stdin/out method is
>>> far nicer.
>>>
>>> I have this set up on:
>>> https://github.com/AeroNotix/otp/tree/feat/erl_tidy_print_to_stdout
>>>
>>> I added the requisite source and added the docs for it in the right 
>>> areas.
>>>
>>> Regards,
>>> Aaron
>>>
>>>
>>> _______________________________________________
>>> erlang-patches mailing list
>>> 
>>> http://erlang.org/mailman/listinfo/erlang-patches
>> Hello Aaron,
>> We are interested in this patch but before we can merge it we need tests
>> and further documentation.
>>
>> -- 
>>
>> BR Fredrik Gustafsson
>> Erlang OTP Team
>
> Considering that he did document the new option, and that erl_tidy 
> (and the whole of syntax_tools) currently has almost no tests, I think 
> this patch should be accepted as it is.

It is great that the new option is documented!

Especially since syntax_tools is lacking tests, I think it's crucial 
that tests are added.

It is our policy to require tests for all new features unless the 
feature is already covered under some other test.

// Björn-Egil
    Erlang/OTP


>
>    /Richard
>
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches
>
>



More information about the erlang-patches mailing list