[erlang-patches] Allow rb to use any io_device/registered name instead of only filename path

Siri Hansen <>
Tue Jul 9 09:21:11 CEST 2013


Eric, I'm sorry for the delay! I've looked at your patch again, and I think
it looks good now. I would like you to amend your commits into one single
commit since keeping them separate does not add any value imo.

Also, you need to add tests for all changed code. There is an rb_SUITE in
sasl/test which can be extended.

Regards
/siri

2013/6/20 Fredrik <>

> On 06/19/2013 11:23 PM, PAILLEAU Eric wrote:
>
>> Le 19/06/2013 10:19, Siri Hansen a écrit :
>>
>>> Hi Eric - I am looking at this patch, and I find the diff a bit strange.
>>> I see in the first commit that you updated the documentation (rb.xml)
>>> for e.g. rb:start:
>>>
>>> e.g.
>>> -<v>FileName = string() | standard_io</v>
>>> +<v>FileName = string() | atom() | pid()</v>
>>>
>>> but this is backed out again in your second commit, although is seems
>>> the code is still there (and, as far as I can understand, this
>>> functionality is also the main point of the patch). Could you please
>>> have a look at it? Did something go wrong in a merge or rebase?
>>>
>>> Regards
>>>
>> Hello Siri,
>> yes you are true.
>> I fixed this.
>> Fredik can refetch.
>> Regards
>>
> Re-fetched.
> Thanks,
>
> --
>
> BR Fredrik Gustafsson
> Erlang OTP Team
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130709/65db44d6/attachment.html>


More information about the erlang-patches mailing list