[erlang-patches] Implement ./otp_build configure --enable-silent-rules

Anthony Ramine <>
Tue Jan 29 10:57:10 CET 2013


V_CC and its friends are not valid shells commands as they may start with an @, I don't think CC itself should behave the same way.

The maintainability shouldn't be a concern as only people in the know ever touch these makefiles anyway, and no one should modify them without looking at the other targets and commands for inspiration and code consistency.

That being said, I won't take it personally if the patch is reverted, but Bjorn-Egil himself seems to quite like it :)

-- 
Anthony Ramine

Le 29 janv. 2013 à 10:16, <> a écrit :

> Anthony Ramine writes:
>> Do you mean actually including the prefix to CC, LD, ERLC and their friends?
> 
> Yes.
> 
>> First that would make me unable to print ASN1 or YECC instead of ERLC when
>> the target isn't a .beam file; second that would break the expectation of
> 
> You could sed something appropriate out of $@, or just echo the
> target.
> 
>> the users that CC, LD, ERLC and the other variables are just paths to
>> compilers.
> 
> That is ends with a path is an expectation, not sure how many assume
> that it's only a path.
> 
> I just think that the support will degenerate and/or be inconsistently
> used as long as its maintained in application makefiles.
> 
> Anders
> 
> 
> 
>> 
>> -- 
>> Anthony Ramine
>> 
>> Le 29 janv. 2013 à 09:32, <> <> a écrit :
>> 
>>> Anthony Ramine writes:
>>>> Hi,
>>>> 
>>>> I've added a commit that document output.mk.in as requested;
>>>> please refetch.
>>>> 
>>>> Anders, please tell me if things aren't clear enough and you want
>>>> me to rewrite/detail.
>>> 
>>> Sorry for the slow reply.
>>> 
>>> The description itself is fine but I can't say I think that manually
>>> specifying what should be echoed in each individual makefile is a good
>>> idea. If the verbosity is controlled by the value of V (if I
>>> understand correctly), why can't you implement something like this in
>>> otp.mk, by adding the appropriate command prefix to the relevant
>>> compiler macros?
>>> 
>>> Anders
>>> 
>>> 
>>> 
>>>> 
>>>> Regards,
>>>> 
>>>> -- 
>>>> Anthony Ramine
>>>> 
>>>> Le 19 janv. 2013 à 12:15, Anthony Ramine a écrit :
>>>> 
>>>>> Hi,
>>>>> 
>>>>> I've recreated the branch with two new commits, adding support of silent rules
>>>>> in wx and when running ./otp_build tests.
>>>>> 
>>>>> Please refetch.
>>>>> 
>>>>> Regards,
>>>>> 
>>>>> -- 
>>>>> Anthony Ramine
>>>>> 
>>>>> Le 18 janv. 2013 à 14:43, Björn-Egil Dahlberg a écrit :
>>>>> 
>>>>>> Patch merged.
>>>>>> Closing issue designated OTP-10726.
>>>>>> 
>>>>>> // Björn-Egil
>>>>>> 
>>>>>> On 2013-01-16 14:59, Björn-Egil Dahlberg wrote:
>>>>>>> On 2013-01-15 21:46, Anthony Ramine wrote:
>>>>>>>> I couldn't reproduce the bug here but apparently I've found the cause of it.
>>>>>>> Looking good.
>>>>>>> 
>>>>>>> Putting it into master-opu integration branch.
>>>>>>> 
>>>>>>> Will be merged later this week if no other issues appear.
>>>>>>> 
>>>>>>> // Björn-Egil
>>>>>>> 
>>>>>>>> 
>>>>>>>> I've removed $(V_MAKE) and put back $(make_verbose)$(MAKE):
>>>>>>>> 
>>>>>>>>> Using the MAKE variable has the same effect as using a ‘+’ character
>>>>>>>>> at the beginning of the recipe line. See Instead of Executing the
>>>>>>>>> Recipes. This special feature is only enabled if the MAKE variable
>>>>>>>>> appears directly in the recipe: it does not apply if the MAKE variable
>>>>>>>>> is referenced through expansion of another variable. In the latter
>>>>>>>>> case you must use the ‘+’ token to get these special effects.
>>>>>>>> http://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable 
>>>>>>>> 
>>>>>>>> Please refetch.
>>>>>>>> 
>>>>>>>> Regards,
>>>>>>> 
>>>>>>> _______________________________________________
>>>>>>> erlang-patches mailing list
>>>>>>> 
>>>>>>> http://erlang.org/mailman/listinfo/erlang-patches
>>>>>> 
>>>>>> _______________________________________________
>>>>>> erlang-patches mailing list
>>>>>> 
>>>>>> http://erlang.org/mailman/listinfo/erlang-patches
>> 


More information about the erlang-patches mailing list