[erlang-patches] odbc:param_query/3 and odbc:param_query/4

Fredrik <>
Fri Jan 25 09:54:45 CET 2013


On 01/25/2013 08:48 AM, Rubber Cthulhu wrote:
> Hello Fredrik.
> I'm sorry for delay. I didn't deal with test system in erlang earlier
> and I had to see into it. Besides running tests for odbc was
> nontrivial.
> But now it's done.
>
> git fetch :RubberCthulhu/otp.git odbc-empty-params-master
>
> That patch includes previous changes:
>
> https://github.com/RubberCthulhu/otp/compare/erlang:master...odbc-empty-params-master
> https://github.com/RubberCthulhu/otp/compare/erlang:master...odbc-empty-params-master.patch
>
> And that includes only testcases:
>
> https://github.com/RubberCthulhu/otp/commit/026d6778fdadce1eac8cdf486b159fa0d6669836
> https://github.com/RubberCthulhu/otp/commit/026d6778fdadce1eac8cdf486b159fa0d6669836.patch
>
> 2013/1/21 Fredrik<>:
>> Hello again,
>> Could you provide a testcase for this patch?
>>
>>
>> BR Fredrik Gustafsson
>> Erlang OTP Team
>> On 01/11/2013 07:50 AM, Danil Onishchenko wrote:
>>> Hello, Fredrik.
>>> I rebased that patch on 'master' branch. The previous version was
>>> based on 'maint'.
>>>
>>> git fetch :RubberCthulhu/otp.git odbc-empty-params-master
>>>
>>>
>>> https://github.com/RubberCthulhu/otp/compare/erlang:master...odbc-empty-params-master
>>>
>>> https://github.com/RubberCthulhu/otp/compare/erlang:master...odbc-empty-params-master.patch
>>>
>>> 2013/1/9 Fredrik<>:
>>>> Hello Kernel!
>>>> Your patch is now cooking in the 'master-pu' branch.
>>>>
>>>> BR Fredrik Gustafsson
>>>> Erlang OTP Team
>>>>
>>>> On 01/09/2013 10:29 AM, Kernel Panic wrote:
>>>>> A little patch for odbc:param_query/3 and odbc:param_query/4.
>>>>>
>>>>> Issue: Calling odbc:param_query/3 and odbc:param_query/4 with
>>>>> unparameterized query string and empty parameters list causes error in
>>>>> pattern matching in function param_values/1.
>>>>>
>>>>> This patch fixes this problem and allow to do things such as
>>>>> odbc:param_query(ConRef, "select * from some_table", []).
>>>>>
>>>>> git fetch :RubberCthulhu/otp.git odbc-empty-params
>>>>>
>>>>> https://github.com/RubberCthulhu/otp/compare/odbc-empty-params
>>>>> https://github.com/RubberCthulhu/otp/compare/odbc-empty-params.patch
>>>>> _______________________________________________
>>>>> erlang-patches mailing list
>>>>> 
>>>>> http://erlang.org/mailman/listinfo/erlang-patches
>>>>
Hello,
Re-fetched.
Thanks,

-- 

BR Fredrik Gustafsson
Erlang OTP Team



More information about the erlang-patches mailing list