[erlang-patches] Shell History to Erlang

Fred Hebert <>
Fri Jan 18 15:22:27 CET 2013


Hi Dan,

There is no search functionality in this patch. I'm thinking this
comment might have needed to go to
http://erlang.org/pipermail/erlang-patches/2012-December/003242.html

In any case, the use of 'Esc' is ambiguous to exit search because the
character used in the escape sequence is the same one used while using
meta (\e if I recall). Because the shell handles things in a
character-per-character basis, there is no way for me to know whether
I'm looking at a meta sequence or if I'm getting 'Esc' on its own.

Supporting 'Esc' to escape search then means that I may leave garbage in
the line when what I get is actually a meta sequence.

Not sure how to work around this one.

Regards,
Fred.

On 01/18, Dan Gudmundsson wrote:
> Starting to review this one, it might take awhile I don't know
> anything about edlin and group functionality. So have some patience
> with me..sigh scrum..:-)
> 
> Some issues to start with.
> 
> While testing this I used 'Esc' to abort the search, which works in bash.
> But here an hidden 'quote' get inserted and confuses the user (at least me).
> 
> Also I guess it should be mentioned somewhere in the docs.
> 
> Running a ssh shell to erlang's ssh deamon doesn't work, since the
> protocol is changed I guess.
> 
> /Dan
> 
> On Tue, Dec 18, 2012 at 5:07 PM, Fredrik <> wrote:
> > Since not anyone have had the time to look into it in detail, getting it
> > like a patch would put it in the "tasks queue" for us to review it. In that
> > way you would get a decision much faster.
> > We think it would be a cool feature but it needs to be reviewed and have
> > been run in all the tests before taking a decision.
> >
> >
> > BR Fredrik Gustafsson
> > Erlang OTP Team
> > On 12/18/2012 04:31 PM, Fred Hebert wrote:
> >>
> >> Does this mean it has a chance of making it there? The original thread I
> >> posted months ago asked if there were any chances for it to be included.
> >> If the OTP team is not interested in the solution in any way, it's no
> >> use losing my time formatting only to have it dismissed -- that's why I
> >> asked the question in the first place, and never got an answer.
> >>
> >> If there's a chances the OTP team is interested, I'll try and find the
> >> time to format things and send it as a proper patch.
> >>
> >> Regards,
> >> Fred.
> >>
> >> On 12/18, Fredrik wrote:
> >>>
> >>> Could you please follow the instructions here:
> >>> https://github.com/erlang/otp/wiki/submitting-patches
> >>> And we will review your patch.
> >>>
> >>> BR Fredrik Gustafsson
> >>> Erlang OTP Team
> >>> On 12/18/2012 02:15 PM, Fred Hebert wrote:
> >>>>
> >>>> Here's the original description back from February:
> >>>> http://erlang.org/pipermail/erlang-patches/2012-February/002645.html
> >>>>
> >>>> Regards,
> >>>> Fred.
> >>>>
> >>>> On 12/18, Fredrik wrote:
> >>>>>
> >>>>> Hello Andrew!
> >>>>> What patch is this about?
> >>>>>
> >>>>> BR Fredrik Gustafsson
> >>>>> Erlang OTP Team
> >>>>> On 12/17/2012 08:23 PM, Andrew Thompson wrote:
> >>>>>>
> >>>>>> On Mon, Feb 13, 2012 at 10:28:33AM +0100, Henrik Nord wrote:
> >>>>>>>
> >>>>>>> This will have to wait for a technical board meeting. I will let you
> >>>>>>> know as soon as the meeting has been held.
> >>>>>>
> >>>>>> It's been 10 months, are there any updates on this?
> >>>>>>
> >>>>>> Andrew
> >>>>>> _______________________________________________
> >>>>>> erlang-patches mailing list
> >>>>>> 
> >>>>>> http://erlang.org/mailman/listinfo/erlang-patches
> >>>>>
> >>>>> _______________________________________________
> >>>>> erlang-patches mailing list
> >>>>> 
> >>>>> http://erlang.org/mailman/listinfo/erlang-patches
> >>>
> >>> _______________________________________________
> >>> erlang-patches mailing list
> >>> 
> >>> http://erlang.org/mailman/listinfo/erlang-patches
> >
> >
> > _______________________________________________
> > erlang-patches mailing list
> > 
> > http://erlang.org/mailman/listinfo/erlang-patches


More information about the erlang-patches mailing list