[erlang-patches] [patch] Added application:get_env/3

Dan Gudmundsson <>
Tue Jan 15 10:19:03 CET 2013


Hi

Since the return value differs in get_env/2 and get_env/3 it should be
documented
as separate function.

/Dan

On Mon, Jan 14, 2013 at 7:28 PM, Serge Aleynikov <> wrote:
> Please refetch both branches. Removed ?line macro in new test cases and
> fixed the missing spec.
>
> On 1/14/2013 9:55 AM, Fredrik wrote:
>> Hello,
>> The answer is nothing. Just remove the '?line' that you've added. The
>> principle is that if we adding code we don't include the ?line and if we
>> are changing the code we are removing ?line from the lines we are
>> changing. Not removing anything else right now.
>>
>> BR Fredrik Gustafsson
>> Erlang OTP Team
>> On 01/14/2013 03:52 PM, Serge Aleynikov wrote:
>>> Fredrik,
>>>
>>> What should be used in place of the ?line macro?  All test cases in that
>>> file use the ?line macro, e.g. see application_SUITE:get_key/1.
>>>
>>> Serge
>>>
>>> On 1/14/2013 5:13 AM, Fredrik wrote:
>>>> Hello Serge,
>>>> Your patch is under review but I noticed during examination that you are
>>>> using the ?line macro in your testcase provided. This is not used
>>>> anymore and therefore should not be included, could you fix this?
>>>>
>>>> BR Fredrik Gustafsson
>>>> Erlang OTP Team
>>>> On 01/10/2013 03:31 PM, Serge Aleynikov wrote:
>>>>> Added an application:get_env/3 function variant that provides a default
>>>>> value for a configuration parameter:
>>>>>
>>>>>      application:get_env(App, Key, Default) ->   Value.
>>>>>
>>>>> git fetch git://github.com/saleyn/otp.git get_env
>>>>>
>>>>> https://github.com/saleyn/otp/compare/erlang:master...get_env
>>>>> https://github.com/saleyn/otp/compare/erlang:master...get_env.patch
>>>>> _______________________________________________
>>>>> erlang-patches mailing list
>>>>> 
>>>>> http://erlang.org/mailman/listinfo/erlang-patches
>>
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches


More information about the erlang-patches mailing list