[erlang-patches] minor ftp and application_controller fixes

Fredrik <>
Thu Jan 10 17:19:10 CET 2013


Hello,
I don't think the reason why no failures is tested is because the reason 
you are giving.
If you are not going to write testcase for this, I will do it when I get 
time.
Maybe I will do it for more scenarios than yours also.
Don't know the timeframe for this, but I'll do it when I get time.
Is this OK with you?

BR Fredrik Gustafsson
Erlang OTP Team
On 01/10/2013 04:54 PM, Fredrik wrote:
> I see,
> I will discuss with responsible developers and get back to you.
> It is now in 'master-pu' again, for tests to be examined.
>
> BR Fredrik Gustafsson
> Erlang OTP Team
> On 01/10/2013 04:30 PM, Serge Aleynikov wrote:
>> I am not certain if either of the two bug fixes require me to provide
>> test cases.  Neither one of the two functionalities currently have test
>> cases.  The application_controller fix is merely a formatting change,
>> and the ftp fix is an introduction of error handling of a missing error
>> code.  The later was discussed with Henric Nord, and my last (attached)
>> email on the subject was unanswered.
>>
>> Regards,
>>
>> Serge
>>
>> On 1/10/2013 10:06 AM, Fredrik wrote:
>>> Hello,
>>> I have noticed in our system that we are waiting for tests for this
>>> patch. I'm just checking that you have got this info?
>>>
>>> BR Fredrik Gustafsson
>>> Erlang OTP Team
>>> On 12/05/2012 04:10 PM, Serge Aleynikov wrote:
>>>> It makes sense.  Thanks.
>>>>
>>>> On 12/5/2012 5:40 AM, Henrik Nord wrote:
>>>>> Hello
>>>>>
>>>>> Since ~p causes line breaks that we don't want in the crash dump 
>>>>> slogan,
>>>>> we don't want to take this directly, but the formatting of strings is
>>>>> still so tempting that we would really like a ~p with no line beak...
>>>>> Since there is no way to set line length to infinity, we need to just
>>>>> set it to "very long" - e.g.
>>>>>
>>>>> |    lists:flatten(io_lib:format("~134217728p", [Term]))
>>>>>
>>>>>
>>>>> |||
>>>>>
>>>>> I will update your patch accordingly, Thank you for your 
>>>>> contribution!
>>>>>
>>>>>
>>>>> ||||
>>>>>
>>>>> On 10/12/2012 06:10 AM, Serge Aleynikov wrote:
>>>>>> 2. Fixed printout of application crash message on startup.
>>>>>>
>>>>>> git fetch :saleyn/otp.git app_controller
>>>>>>
>>>>>> https://github.com/saleyn/otp/compare/app_controller
>>>>>> https://github.com/saleyn/otp/compare/app_controller.patch
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Serge
>
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches



More information about the erlang-patches mailing list