[erlang-patches] new veriosn elliptic curve support

Mon Feb 25 14:56:56 CET 2013

On 02/22/2013 03:01 PM, Andreas Schultz wrote:
> Hi,
>
> Updated version pushed, I don't have windows around, so I couldn't test the change.
> Static initialization in crypto.c and unused symbols are changed as well.
>
> git fetch git://github.com/RoadRunnr/otp.git tls-psk-srp-suites-ECC
>
> https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites-ECC
> https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites-ECC.patch
>
> Andreas
>
> ----- Original Message -----
>> On 02/22/2013 11:45 AM, Fredrik wrote:
>>> On 02/22/2013 10:46 AM, Fredrik wrote:
>>>> On 02/21/2013 04:13 PM, Andreas Schultz wrote:
>>>>> Hi,
>>>>>
>>>>> Sorry, messed up a merge, new version compiled, passed the SSL test
>>>>> suite and pushed... even with a fetch line: ;-)
>>>>>
>>>>> git fetch git://github.com/RoadRunnr/otp.git tls-psk-srp-suites-ECC
>>>>>
>>>>> BTW: @Ingela: I noticec that the ssl_packet_SUITE is not executed
>>>>> during
>>>>> tests. This looks like a mistake in the common_test conversion.
>>>>>
>>>>> Andreas
>>>>>
>>>>> ----- Original Message -----
>>>>>> On 02/21/2013 02:05 PM, Andreas Schultz wrote:
>>>>>>> ----- Original Message -----
>>>>>>>> On 02/21/2013 01:48 PM, Andreas Schultz wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I have a new version of the elliptic curve TLS support.
>>>>>>>>>
>>>>>>>>> https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites-ECC
>>>>>>>>>
>>>>>>>>> https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites-ECC.patch
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> This branch includes the PSK and SRP cipher changes that are
>>>>>>>>> already in
>>>>>>>>> master-pu
>>>>>>>>> as it would otherwise conflict with them.
>>>>>>>>>
>>>>>>>>> EC ciphers are now optional and depend on wether EC support is
>>>>>>>>> compiled
>>>>>>>>> into
>>>>>>>>> OpenSSL or not. I have tested it with on Fedora (without EC
>>>>>>>>> support) and
>>>>>>>>> Ubuntu
>>>>>>>>> (with EC support).
>>>>>>>>>
>>>>>>>>> Andreas
>>>>>>>>> _______________________________________________
>>>>>>>>> erlang-patches mailing list
>>>>>>>>> erlang-patches@REDACTED
>>>>>>>>> http://erlang.org/mailman/listinfo/erlang-patches
>>>>>>>> Fetched,
>>>>>>>> Dropping tls-psk-srp-suites
>>>>>>>>
>>>>>>>> and replacing it with this patch now, correct?
>>>>>>> yes, thanks
>>>>>>>
>>>>>>> Andreas
>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> BR Fredrik Gustafsson
>>>>>>>> Erlang OTP Team
>>>>>>>>
>>>>>>>>
>>>>>> Fails to build:
>>>>>>
>>>>>> ssl_connection.erl:1362: syntax error before: '>>'
>>>>>> ssl_connection.erl:1230: function init_diffie_hellman/4 undefined
>>>>>> ssl_connection.erl:1351: Warning: function handle_file_error/6 is
>>>>>> unused
>>>>>> ssl_connection.erl:1357: Warning: function file_error/6 is unused
>>>>>> ssl_connection.erl:2141: Warning: variable 'Session' is unused
>>>>>> ssl_connection.erl:2142: Warning: variable 'Role' is unused
>>>>>> ssl_connection.erl:2142: Warning: variable 'Version' is unused
>>>>>> ssl_connection.erl:2143: Warning: variable 'ConnectionStates0' is
>>>>>> unused
>>>>>> ssl_connection.erl:2148: Warning: variable 'PSKIdentity' is unused
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> BR Fredrik Gustafsson
>>>>>> Erlang OTP Team
>>>>>>
>>>>>>
>>>> Re-fetched. Thanks,
>>>> Fetch link is always appreciated. ;)
>>>>
>>> Still fails to build:
>>>
>>> crypto.c(369) : error C2059: syntax error : '.'
>>> crypto.c(370) : error C2059: syntax error : ','
>>> crypto.c(371) : error C2059: syntax error : ','
>>> crypto.c(372) : error C2059: syntax error : ','
>>> crypto.c(373) : error C2059: syntax error : ','
>>> crypto.c(374) : error C2059: syntax error : ','
>>> crypto.c(375) : error C2059: syntax error : ','
>>> crypto.c(377) : error C2059: syntax error : ','
>>> crypto.c(378) : error C2059: syntax error : ','
>>> crypto.c(379) : error C2059: syntax error : ','
>>> crypto.c(380) : error C2059: syntax error : ','
>>> crypto.c(381) : error C2059: syntax error : ','
>>> crypto.c(383) : error C2059: syntax error : ','
>>> crypto.c(384) : error C2059: syntax error : ','
>>> crypto.c(385) : error C2059: syntax error : ','
>>> crypto.c(387) : error C2059: syntax error : ','
>>> crypto.c(388) : error C2059: syntax error : ','
>>> crypto.c(389) : error C2059: syntax error : ','
>>> crypto.c(390) : error C2059: syntax error : ','
>>> crypto.c(391) : error C2059: syntax error : ','
>>> crypto.c(392) : error C2059: syntax error : ','
>>> crypto.c(393) : error C2059: syntax error : ','
>>> crypto.c(396) : error C2059: syntax error : ','
>>> crypto.c(397) : error C2059: syntax error : ','
>>> crypto.c(398) : error C2059: syntax error : ','
>>> crypto.c(399) : error C2059: syntax error : ','
>>> crypto.c(400) : error C2059: syntax error : ','
>>> crypto.c(401) : error C2059: syntax error : ','
>>> crypto.c(402) : error C2059: syntax error : ','
>>> crypto.c(403) : error C2059: syntax error : ','
>>> crypto.c(404) : error C2059: syntax error : ','
>>> crypto.c(405) : error C2059: syntax error : ','
>>> crypto.c(406) : error C2059: syntax error : ','
>>> crypto.c(407) : error C2059: syntax error : ','
>>> crypto.c(408) : error C2059: syntax error : ','
>>> crypto.c(409) : error C2059: syntax error : ','
>>> crypto.c(410) : error C2059: syntax error : ','
>>> crypto.c(411) : error C2059: syntax error : ','
>>> crypto.c(412) : error C2059: syntax error : ','
>>> crypto.c(413) : error C2059: syntax error : ','
>>> crypto.c(415) : error C2059: syntax error : ','
>>> crypto.c(416) : error C2059: syntax error : ','
>>> crypto.c(417) : error C2059: syntax error : ','
>>> crypto.c(418) : error C2059: syntax error : ','
>>> crypto.c(419) : error C2059: syntax error : ','
>>> crypto.c(420) : error C2059: syntax error : ','
>>> crypto.c(421) : error C2059: syntax error : ','
>>> crypto.c(422) : error C2059: syntax error : ','
>>> crypto.c(423) : error C2059: syntax error : ','
>>> crypto.c(424) : error C2059: syntax error : ','
>>> crypto.c(425) : error C2059: syntax error : ','
>>> crypto.c(426) : error C2059: syntax error : ','
>>> crypto.c(427) : error C2059: syntax error : ','
>>> crypto.c(428) : error C2059: syntax error : ','
>>> crypto.c(429) : error C2059: syntax error : ','
>>> crypto.c(430) : error C2059: syntax error : ','
>>> crypto.c(433) : error C2059: syntax error : ','
>>> crypto.c(434) : error C2059: syntax error : ','
>>> crypto.c(435) : error C2059: syntax error : ','
>>> crypto.c(436) : error C2059: syntax error : ','
>>> crypto.c(437) : error C2059: syntax error : ','
>>> crypto.c(438) : error C2059: syntax error : ','
>>> crypto.c(439) : error C2059: syntax error : ','
>>> crypto.c(440) : error C2059: syntax error : ','
>>> crypto.c(441) : error C2059: syntax error : ','
>>> crypto.c(442) : error C2059: syntax error : ','
>>> crypto.c(443) : error C2059: syntax error : ','
>>> crypto.c(445) : error C2059: syntax error : ','
>>> crypto.c(447) : error C2059: syntax error : '}'
>>> crypto.c(611) : warning C4034: sizeof returns 0
>>> crypto.c(2832) : warning C4034: sizeof returns 0
>>> crypto.c(2843) : warning C4034: sizeof returns 0
>>>
>>>
>>>
>> This is only on windows I should add also!
>>
>> --
>>
>> BR Fredrik Gustafsson
>> Erlang OTP Team
>>
>>
Hello,
Your patch is failing several testcases:

In crypto:
Suite: crypto_SUITE, Testcase: ec
Reason:
crypto:ecdsa_sign failed on line 1153 Reason: badkey

In ssl:
ssl_to_openssl_SUITE, basic_erlang_server_openssl_client,
Reason:
ssl_to_openssl_SUITE:basic_erlang_server_openssl_client failed on line 
249 Reason: {test_case_failed,{{expected,{<0.11346.0>,ok}}, 
{got,{'EXIT',#Port<0.11738>,normal}}}}

ssl_to_openssl_SUITE, erlang_server_openssl_client
Reason:
ssl_to_openssl_SUITE:erlang_server_openssl_client failed on line 322 
Reason: {test_case_failed,{{expected,{<0.11609.0>,ok}}, 
{got,{'EXIT',#Port<0.11893>,normal}}}}
ssl_to_openssl_SUITE, erlang_server_openssl_client_client_cert
Reason:
ssl_to_openssl_SUITE:erlang_server_openssl_client_client_cert failed on 
line 699 Reason: {test_case_failed,{{expected,{<0.11661.0>,ok}}, 
{got,{'EXIT',#Port<0.11939>,normal}}}}
ssl_to_openssl_SUITE, erlang_server_openssl_client_dsa_cert
Reason:
**** User 2013-02-25 11:28:12.865 
****ssl_to_openssl_SUITE:erlang_server_openssl_client_dsa_cert failed on 
line 404 Reason: {test_case_failed,{{expected,{<0.11622.0>,ok}}, 
{got,{'EXIT',#Port<0.11908>,normal}}}}
ssl_to_openssl_SUITE, erlang_server_openssl_client_reuse_session
Reason:
ssl_to_openssl_SUITE:erlang_server_openssl_client_reuse_session failed 
on line 440 Reason: {test_case_failed,{{expected,{<0.11628.0>,ok}}, 
{got,{'EXIT',#Port<0.11915>,normal}}}}
ssl_to_openssl_SUITE, ciphers_rsa_signed_certs
Reason:
Error detected: testcase_aborted_or_killed

-- 

BR Fredrik Gustafsson
Erlang OTP Team

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130225/47943fe6/attachment.htm>