[erlang-patches] [PATCH] epmd: support IPv6 node registration

[Patrik Nyblom]

Hi!

On 02/20/2013 02:04 PM, Michael Santos wrote:
> On Tue, Feb 19, 2013 at 06:08:47PM +0100, Patrik Nyblom wrote:
>> On 02/18/2013 12:28 PM, Fredrik wrote:
>>> This happens only on windows I should add to the context also..
>>>
>>> BR Fredrik
>>> On 02/18/2013 12:00 PM, Fredrik wrote:
>> For unknown reasons, you need to drop support for win2k to get
>> IPPROTO_IPV6 from the windows headers. Either we can up the command
>> line -D_WIN32_WINVER to 0x0501 (Windows XP) or you can set (#define
>> it) in epmd_int.h before including winsock2.h.
>> ...
>> #ifdef _WIN32_WINVER
>> #undef _WIN32_WINVER
>> #endif
>> #define _WIN32_WINVER 0x0501
>> ...
> That was a huge help, thanks!
>
>> But that will probably be the end of any (theoretical) windows 2000
>> support. We don't support Win 2000 officially, so I think it will be
>> a non-issue. Others might disagree though :)
> For now, I've set the define. But if anyone feels strongly about this,
> I can change it.
I've asked around, and we are pretty sure we should change the global 
define anyway. Win 2000 cannot build Erlang and it will probably not 
work there even if built elsewhere. (not that anyone have tried for the 
last couple of years...) The flag was added to explicitly force away NT4 
to be able to use proper threading API's back in the days :)

I think we can safely set the windows version to 0x0501 already in the 
forthcoming maint (after the release). So then we can remove the #define.

Thanks for the patch!
> _______________________________________________
> erlang-patches mailing list
> erlang-patches@REDACTED
> http://erlang.org/mailman/listinfo/erlang-patches
/Patrik