[erlang-patches] new veriosn elliptic curve support

[Andreas Schultz]

Hi Michael,

The static in crypto:algorithms/0 is used to perform the initialization of
the list of supported algos only once. Looking it again if have to admit
that there is a small windows for a race that would overrun the static array
if two process called it at the time when cnt is zero.

I'll move the initialization to the init function...

Andreas


----- Original Message -----
> When I took a quick look at this I see there are static's in the
> function algorithms.  I'm honestly not sure how erlang is using
> threading...and I don't remember if there are other examples of this
> in the code base, but, it strikes me as that is going to be inherently
> thread unsafe since I believe multiple threads could race to start
> updating those statics the first time through.  You could easily end
> up with one thread starting an update and another thread then
> attempting to run.
> 
> On Thu, Feb 21, 2013 at 7:13 AM, Andreas Schultz <aschultz@REDACTED> wrote:
> > Hi,
> >
> > Sorry, messed up a merge, new version compiled, passed the SSL test
> > suite and pushed... even with a fetch line: ;-)
> >
> > git fetch git://github.com/RoadRunnr/otp.git tls-psk-srp-suites-ECC
> >
> > BTW: @Ingela: I noticec that the ssl_packet_SUITE is not executed during
> > tests. This looks like a mistake in the common_test conversion.
> >
> > Andreas
> >
> > ----- Original Message -----
> >> On 02/21/2013 02:05 PM, Andreas Schultz wrote:
> >> >
> >> > ----- Original Message -----
> >> >> On 02/21/2013 01:48 PM, Andreas Schultz wrote:
> >> >>> Hi,
> >> >>>
> >> >>> I have a new version of the elliptic curve TLS support.
> >> >>>
> >> >>> https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites-ECC
> >> >>> https://github.com/RoadRunnr/otp/compare/master...tls-psk-srp-suites-ECC.patch
> >> >>>
> >> >>> This branch includes the PSK and SRP cipher changes that are already
> >> >>> in
> >> >>> master-pu
> >> >>> as it would otherwise conflict with them.
> >> >>>
> >> >>> EC ciphers are now optional and depend on wether EC support is
> >> >>> compiled
> >> >>> into
> >> >>> OpenSSL or not. I have tested it with on Fedora (without EC support)
> >> >>> and
> >> >>> Ubuntu
> >> >>> (with EC support).
> >> >>>
> >> >>> Andreas
> >> >>> _______________________________________________
> >> >>> erlang-patches mailing list
> >> >>> erlang-patches@REDACTED
> >> >>> http://erlang.org/mailman/listinfo/erlang-patches
> >> >> Fetched,
> >> >> Dropping tls-psk-srp-suites
> >> >>
> >> >> and replacing it with this patch now, correct?
> >> > yes, thanks
> >> >
> >> > Andreas
> >> >
> >> >> --
> >> >>
> >> >> BR Fredrik Gustafsson
> >> >> Erlang OTP Team
> >> >>
> >> >>
> >> Fails to build:
> >>
> >> ssl_connection.erl:1362: syntax error before: '>>'
> >> ssl_connection.erl:1230: function init_diffie_hellman/4 undefined
> >> ssl_connection.erl:1351: Warning: function handle_file_error/6 is unused
> >> ssl_connection.erl:1357: Warning: function file_error/6 is unused
> >> ssl_connection.erl:2141: Warning: variable 'Session' is unused
> >> ssl_connection.erl:2142: Warning: variable 'Role' is unused
> >> ssl_connection.erl:2142: Warning: variable 'Version' is unused
> >> ssl_connection.erl:2143: Warning: variable 'ConnectionStates0' is unused
> >> ssl_connection.erl:2148: Warning: variable 'PSKIdentity' is unused
> >>
> >>
> >>
> >> --
> >>
> >> BR Fredrik Gustafsson
> >> Erlang OTP Team
> >>
> >>
> >
> > --
> > --
> > Dipl. Inform.
> > Andreas Schultz
> >
> > email: as@REDACTED
> > phone: +49-391-819099-224
> > mobil: +49-170-2226073
> >
> > ------------------ managed broadband access ------------------
> >
> > Travelping GmbH               phone:           +49-391-8190990
> > Roentgenstr. 13               fax:           +49-391-819099299
> > D-39108 Magdeburg             email:       info@REDACTED
> > GERMANY                       web:   http://www.travelping.com
> >
> > Company Registration: HRB21276 Handelsregistergericht Chemnitz
> > Geschaeftsfuehrer: Holger Winkelmann | VAT ID No.: DE236673780
> > --------------------------------------------------------------
> > _______________________________________________
> > erlang-patches mailing list
> > erlang-patches@REDACTED
> > http://erlang.org/mailman/listinfo/erlang-patches
> 
> 
> 
> --
> 
> "Genius might be described as a supreme capacity for getting its possessors
> into trouble of all kinds."
> -- Samuel Butler
> 

-- 
-- 
Dipl. Inform.
Andreas Schultz

email: as@REDACTED
phone: +49-391-819099-224
mobil: +49-170-2226073

------------------ managed broadband access ------------------

Travelping GmbH               phone:           +49-391-8190990
Roentgenstr. 13               fax:           +49-391-819099299
D-39108 Magdeburg             email:       info@REDACTED
GERMANY                       web:   http://www.travelping.com

Company Registration: HRB21276 Handelsregistergericht Chemnitz
Geschaeftsfuehrer: Holger Winkelmann | VAT ID No.: DE236673780
--------------------------------------------------------------